-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] skywalking-pyhton can't pass the e2e test with psutil==5.9.6 #11481
Comments
Hi, thanks for the report. Please kindly paste the e2e log here, so that we know what exactly got broken in 5.9.6? Since restricting the package version will impact user env too, we want the version constraint as loose as possible. I don't see any backward incompatible changes with the cpu_percent method, could it be a broken build specific to os? |
The The log for e2e running on macOS is here: The consumer log: The provider log: |
So essentially each and every case fails, that is weird, please hold that PR a bit, I will try run it on my GHA to pinpoint the problem. |
The workaround is merged in apache/skywalking-python#326 but lets keep this issue open until next release, I might fix it up according to upstream changes. |
Search before asking
Apache SkyWalking Component
Python Agent (apache/skywalking-python)
What happened
The e2e tests broke after the psutil 5.9.6 was released, according to the release note:
psutil 5.9.6
Maybe it changed the implementation of the psutil.cpu_percent(), I'm not sure.
When I fixed the psutil==5.9.5, the e2e test passed.
What you expected to happen
The python-agent should work correctly with psutil 5.9.6
How to reproduce
This issue can be reproduced on both ubuntu 20.04 x64 and macOS M1:
The packages on consumer and provider:
Anything else
No response
Are you willing to submit a pull request to fix on your own?
Code of Conduct
The text was updated successfully, but these errors were encountered: