Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #8173] support ratelimit for topic or client ip #8174

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

[ISSUE #8173] support ratelimit for topic or client ip #8174

wants to merge 14 commits into from

Conversation

yuz10
Copy link
Member

@yuz10 yuz10 commented May 20, 2024

Which Issue(s) This PR Fixes

Fixes #8173

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024 •
edited

Codecov Report

Attention: Patch coverage is 28.82414% with 684 lines in your changes are missing coverage. Please review.

Project coverage is 42.71%. Comparing base (1b42515) to head (1c3f8d8).
Report is 1 commits behind head on develop.

Files Patch % Lines
...q/ratelimit/provider/DefaultRatelimitProvider.java 17.24% 70 Missing and 2 partials ⚠️
...ocketmq/broker/processor/AdminBrokerProcessor.java 0.00% 68 Missing ⚠️
...s/command/ratelimit/UpdateRatelimitSubCommand.java 0.00% 59 Missing ⚠️
...s/command/ratelimit/CreateRatelimitSubCommand.java 0.00% 58 Missing ⚠️
...ols/command/ratelimit/ListRatelimitSubCommand.java 0.00% 44 Missing ⚠️
...atelimit/manager/RatelimitMetadataManagerImpl.java 58.00% 26 Missing and 16 partials ⚠️
...s/command/ratelimit/DeleteRatelimitSubCommand.java 0.00% 38 Missing ⚠️
...e/rocketmq/broker/ratelimit/RatelimitPipeline.java 0.00% 37 Missing ⚠️
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 0.00% 29 Missing ⚠️
...rocketmq/remoting/protocol/body/RatelimitInfo.java 0.00% 26 Missing ⚠️
... and 26 more
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #8174      +/-   ##
=============================================
- Coverage      42.90%   42.71%   -0.19%     
- Complexity     10370    10468      +98     
=============================================
  Files           1270     1297      +27     
  Lines          88721    89670     +949     
  Branches       11405    11512     +107     
=============================================
+ Hits           38062    38301     +239     
- Misses         45954    46613     +659     
- Partials        4705     4756      +51

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] support ratelimit for topic or client ip
2 participants
@yuz10 @codecov-commenter