-
Notifications
You must be signed in to change notification settings - Fork 11.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] optimize produceAccumulator #8134
Labels
Comments
Willhow-Gao
added a commit
to Willhow-Gao/rocketmq
that referenced
this issue
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Before Creating the Enhancement Request
Summary
ProduceFAccumulator#send(SendCallback sendCallback) method has a parameter that is never used.A more reasonable approach is to remove the parameters and rename
![image](https://private-user-images.githubusercontent.com/65004897/330458710-b6512c6b-089f-42e7-a57d-2fba20eb91c7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgzMzk2NDcsIm5iZiI6MTcxODMzOTM0NywicGF0aCI6Ii82NTAwNDg5Ny8zMzA0NTg3MTAtYjY1MTJjNmItMDg5Zi00MmU3LWE1N2QtMmZiYTIwZWI5MWM3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE0VDA0MjkwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ2OTc4NDE0ZDc4YmNkZDFhODg3MWM4M2NmODY1N2UyYWM1NTEzZDhhMWQ2MzEzMjIzZjUxMDY1ZGFkNTIzN2EmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.BaTFAbooF8z10fVXGlv53UjeW-jMggMoUquFjVX6lSE)
Motivation
No necessary parameters passed
Describe the Solution You'd Like
remove parameter and rename method
Describe Alternatives You've Considered
Not consider
Additional Context
No response
The text was updated successfully, but these errors were encountered: