-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][fn] Implement pip 401: Support set batching configurations for Pulsar Functions&Sources #23860
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work @jiangpengcheng
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the work!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23860 +/- ##
============================================
+ Coverage 73.57% 74.19% +0.61%
+ Complexity 32624 32215 -409
============================================
Files 1877 1854 -23
Lines 139502 143660 +4158
Branches 15299 16331 +1032
============================================
+ Hits 102638 106587 +3949
+ Misses 28908 28670 -238
- Partials 7956 8403 +447
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Fixes #xyz
Main Issue: #xyz
PIP: #23793
Motivation
Modifications
Verifying this change
Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
--producer-config
argument to include abatchingConfig
fieldDocumentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: jiangpengcheng#37