Apply review suggestion - 1

Author: slawekjaranowski

compat/maven-settings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsBuilder.java

@@ -26,10 +26,11 @@
 import java.io.IOException;
 import java.io.StringReader;
 import java.io.StringWriter;
-import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
 
 import org.apache.maven.building.FileSource;
 import org.apache.maven.building.Source;
@@ -261,11 +262,16 @@ private List<Server> serversByIds(List<Server> servers) {
             return servers;
         }
 
-        ArrayList<Server> result = new ArrayList<>(servers);
-
-        servers.stream().filter(server -> !server.getIds().isEmpty()).forEach(server -> server.getIds()
-                .forEach(id -> result.add(newServer(server, id))));
-        return result;
+        return servers.stream()
+                .flatMap(server -> {
+                    List<String> ids = server.getIds();
+                    if (ids.isEmpty()) {
+                        return Stream.of(server);
+                    } else {
+                        return Stream.concat(Stream.of(server), ids.stream().map(id -> newServer(server, id)));
+                    }
+                })
+                .collect(Collectors.toList());
     }
 
     private Server newServer(Server server, String id) {

compat/maven-settings-builder/src/test/java/org/apache/maven/settings/building/DefaultSettingsBuilderFactoryTest.java

@@ -37,10 +37,6 @@ private File getSettings(String name) {
         return new File("src/test/resources/settings/factory/" + name + ".xml").getAbsoluteFile();
     }
 
-    private org.apache.maven.settings.Server asServer(Server delegate) {
-        return new org.apache.maven.settings.Server(delegate);
-    }
-
     SettingsBuildingResult execute(String settingsName) throws Exception {
         Properties properties = new Properties();
         properties.setProperty("user.home", "/home/user");

impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSettingsBuilder.java

@@ -26,13 +26,14 @@
 import java.io.InputStream;
 import java.nio.file.Path;
 import java.nio.file.Paths;
-import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.function.Supplier;
 import java.util.function.UnaryOperator;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
 
 import org.apache.maven.api.Constants;
 import org.apache.maven.api.ProtoSession;
@@ -241,14 +242,18 @@ private List<Server> serversByIds(List<Server> servers) {
             return servers;
         }
 
-        ArrayList<Server> result = new ArrayList<>(servers);
-
-        servers.stream().filter(server -> !server.getIds().isEmpty()).forEach(server -> server.getIds()
-                .forEach(id -> result.add(Server.newBuilder(server)
-                        .id(id)
-                        .ids(Collections.emptyList())
-                        .build())));
-        return result;
+        return servers.stream()
+                .flatMap(server -> {
+                    List<String> ids = server.getIds();
+                    if (ids.isEmpty()) {
+                        return Stream.of(server);
+                    }
+                    return Stream.concat(Stream.of(server), ids.stream().map(id -> Server.newBuilder(server, true)
+                            .id(id)
+                            .ids(Collections.emptyList())
+                            .build()));
+                })
+                .collect(Collectors.toList());
     }
 
     private Settings interpolate(