From 9c4b0f2a37059ba64c70adc5549e368a7edfc4d6 Mon Sep 17 00:00:00 2001 From: chinnamatli kusumalatha Date: Mon, 13 Jan 2025 10:40:37 +0530 Subject: [PATCH 1/4] DMN Editor can not reopen List expression --- .../src/boxedExpressions/getDefaultBoxedExpression.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/dmn-editor/src/boxedExpressions/getDefaultBoxedExpression.tsx b/packages/dmn-editor/src/boxedExpressions/getDefaultBoxedExpression.tsx index 0d2cb791a05..e44f380a991 100644 --- a/packages/dmn-editor/src/boxedExpressions/getDefaultBoxedExpression.tsx +++ b/packages/dmn-editor/src/boxedExpressions/getDefaultBoxedExpression.tsx @@ -152,7 +152,10 @@ export function getDefaultBoxedExpression({ "@_id": generateUuid(), "@_typeRef": typeRef, expression: [ - undefined!, // SPEC DISCREPANCY: Starting without an expression gives users the ability to select the expression type. + { + "@_id": generateUuid(), + __$$element: "list", + }, ], }; return listExpression; From 49f1cd8dd201eb574ef41588e509e5e73a2d45b0 Mon Sep 17 00:00:00 2001 From: chinnamatli kusumalatha Date: Wed, 29 Jan 2025 15:40:05 +0530 Subject: [PATCH 2/4] fixing issue:DMN Editor can not reopen List expression --- .../src/boxedExpressions/getDefaultBoxedExpression.tsx | 6 ------ 1 file changed, 6 deletions(-) diff --git a/packages/dmn-editor/src/boxedExpressions/getDefaultBoxedExpression.tsx b/packages/dmn-editor/src/boxedExpressions/getDefaultBoxedExpression.tsx index e44f380a991..d402c5d4d20 100644 --- a/packages/dmn-editor/src/boxedExpressions/getDefaultBoxedExpression.tsx +++ b/packages/dmn-editor/src/boxedExpressions/getDefaultBoxedExpression.tsx @@ -151,12 +151,6 @@ export function getDefaultBoxedExpression({ __$$element: "list", "@_id": generateUuid(), "@_typeRef": typeRef, - expression: [ - { - "@_id": generateUuid(), - __$$element: "list", - }, - ], }; return listExpression; } else if (logicType === "invocation") { From a2a6a3a3eb6413e96553672105453dd97f09a45a Mon Sep 17 00:00:00 2001 From: chinnamatli kusumalatha Date: Wed, 29 Jan 2025 16:05:51 +0530 Subject: [PATCH 3/4] updating stories file for list expression --- .../stories/boxedExpressions/List/List.stories.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/boxed-expression-component/stories/boxedExpressions/List/List.stories.tsx b/packages/boxed-expression-component/stories/boxedExpressions/List/List.stories.tsx index c19f64c69c2..99099ffe97e 100644 --- a/packages/boxed-expression-component/stories/boxedExpressions/List/List.stories.tsx +++ b/packages/boxed-expression-component/stories/boxedExpressions/List/List.stories.tsx @@ -42,7 +42,6 @@ export const Base: Story = { __$$element: "list", "@_id": generateUuid(), "@_label": "Expression Name", - expression: [undefined!], }, isResetSupportedOnRootExpression: true, }, From 02ba20fe3c1b2338a7371fb7e3598a66c7fbee75 Mon Sep 17 00:00:00 2001 From: chinnamatli kusumalatha Date: Thu, 30 Jan 2025 12:29:05 +0530 Subject: [PATCH 4/4] fixing tests --- .../tests-e2e/boxedExpressions/list/populate.spec.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/boxed-expression-component/tests-e2e/boxedExpressions/list/populate.spec.ts b/packages/boxed-expression-component/tests-e2e/boxedExpressions/list/populate.spec.ts index 7760a26c68d..fbd86500da2 100644 --- a/packages/boxed-expression-component/tests-e2e/boxedExpressions/list/populate.spec.ts +++ b/packages/boxed-expression-component/tests-e2e/boxedExpressions/list/populate.spec.ts @@ -27,6 +27,7 @@ test.describe("Populate Boxed List", () => { await bee.expression.asList().addEntryAtTop(); await bee.expression.asList().addEntryAtTop(); await bee.expression.asList().addEntryAtTop(); + await bee.expression.asList().addEntryAtTop(); await bee.expression.asList().row(0).selectExpressionMenu.selectLiteral(); await bee.expression.asList().row(1).selectExpressionMenu.selectLiteral();