-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Beta Nodes #5787
Comments
mdproctor
added a commit
to mdproctor/drools
that referenced
this issue
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, BetaNodes implement both tupleSink and ObjectSink to allow them to receive from both sides. This also means that within that node, many operations need a left or a right prefix to indicate the side of the operation.
This code splits the Beta's into two. The right side enters its own class and is added as an adapter delegate property to the beta node. This way, all nodes only have a single parent, and we don't have to have left or right prefixes. I have tried to remove many (but not all) of those prefixes.
Note the code changes the meaning of RightInputAdapterNode. This adapter class is now called RightInputAdapterNode, to mirror the existing LeftInputAdapterNode. What was previously the subnetwork adapter class, called RightInputAdapterNode, has been named more literally after what it actually does, TupleToObjectNode.
It will also make it make future work for different right input strategies to be more easily implemented.
The work should not have any behaviour changes or impact performance in any way.
The text was updated successfully, but these errors were encountered: