Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewMetadataBuilder does not always retain changes in current build #12113

Open
3 tasks
c-thiel opened this issue Jan 27, 2025 · 0 comments
Open
3 tasks

ViewMetadataBuilder does not always retain changes in current build #12113

c-thiel opened this issue Jan 27, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@c-thiel
Copy link
Contributor

c-thiel commented Jan 27, 2025

Apache Iceberg version

main (development)

Query engine

None

Please describe the bug 🐞

There is one edge case we missed in #12067 that might lead to a ViewVersion, added in the current build, not beeing retained:

  1. Add view version 1 and set current
  2. Set retention of versions to 2
  3. Add view versions 2 & 3
  4. Build

The builder should keep all versions (1, 2, 3) because 1 is the current version and must always be retained and neither 2 nor 3 may be discarded as they where added in this build.

A second build should retain 1 (current version) and 3 (highest id of the remaining) and discard 2.

As discussed CC @nastra

Willingness to contribute

  • I can contribute a fix for this bug independently
  • I would be willing to contribute a fix for this bug with guidance from the Iceberg community
  • I cannot contribute a fix for this bug at this time
@c-thiel c-thiel added the bug Something isn't working label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant