Assert partition type must be Record

Author: ajantha-bhat

core/src/main/java/org/apache/iceberg/PartitionStats.java

@@ -19,12 +19,15 @@
 package org.apache.iceberg;
 
 import java.util.Objects;
+import org.apache.iceberg.data.Record;
 import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
 
 public class PartitionStats implements StructLike {
 
   private static final int STATS_COUNT = 12;
 
+  // Storing as StructLike instead of Record as
+  // internal parquet writers can be used in future without modifying the members of this class.
   private StructLike partition;
   private int specId;
   private long dataRecordCount;
@@ -39,6 +42,8 @@ public class PartitionStats implements StructLike {
   private Long lastUpdatedSnapshotId; // null by default
 
   public PartitionStats(StructLike partition, int specId) {
+    Preconditions.checkArgument(
+        partition instanceof Record, "Partition must be an instance of Record");
     this.partition = partition;
     this.specId = specId;
   }
@@ -206,6 +211,8 @@ public <T> T get(int pos, Class<T> javaClass) {
   public <T> void set(int pos, T value) {
     switch (pos) {
       case 0:
+        Preconditions.checkArgument(
+            partition instanceof Record, "Partition must be an instance of Record");
         this.partition = (StructLike) value;
         break;
       case 1:

data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java

@@ -27,6 +27,7 @@
 import java.util.Collection;
 import java.util.Iterator;
 import java.util.List;
+import java.util.Locale;
 import java.util.function.BiFunction;
 import org.apache.iceberg.FileFormat;
 import org.apache.iceberg.HasTableOperations;
@@ -232,7 +233,8 @@ private static OutputFile newPartitionStatsFile(Table table, long snapshotId) {
             ((HasTableOperations) table)
                 .operations()
                 .metadataFileLocation(
-                    fileFormat.addExtension(String.format("partition-stats-%d", snapshotId))));
+                    fileFormat.addExtension(
+                        String.format(Locale.ROOT, "partition-stats-%d", snapshotId))));
   }
 
   private static PartitionStatsRecord recordToPartitionStatsRecord(Record record) {