Skip to content

Commit 2551fc8

Browse files
committed
Clean up
1 parent 16140cc commit 2551fc8

File tree

4 files changed

+7
-26
lines changed

4 files changed

+7
-26
lines changed

core/src/main/java/org/apache/iceberg/SetPartitionStatistics.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import java.util.List;
2222
import java.util.Map;
2323
import java.util.Set;
24-
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
2524
import org.apache.iceberg.relocated.com.google.common.collect.Maps;
2625
import org.apache.iceberg.relocated.com.google.common.collect.Sets;
2726

@@ -36,7 +35,10 @@ public SetPartitionStatistics(TableOperations ops) {
3635

3736
@Override
3837
public UpdatePartitionStatistics setPartitionStatistics(PartitionStatisticsFile file) {
39-
Preconditions.checkArgument(null != file, "partition statistics file must not be null");
38+
if (file == null) {
39+
return this;
40+
}
41+
4042
statsToSet.put(file.snapshotId(), file);
4143
return this;
4244
}

core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -316,8 +316,9 @@ public void testEnableRowLineageViaPropertyAtTableCreation() {
316316
tableDir,
317317
"test",
318318
TEST_SCHEMA,
319-
ImmutableMap.of(TableProperties.ROW_LINEAGE, "true"),
320-
formatVersion);
319+
PartitionSpec.unpartitioned(),
320+
formatVersion,
321+
ImmutableMap.of(TableProperties.ROW_LINEAGE, "true"));
321322
assertThat(table.ops().current().rowLineageEnabled()).isTrue();
322323
}
323324

core/src/test/java/org/apache/iceberg/TestTables.java

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -52,26 +52,6 @@ public static TestTable create(
5252
return create(temp, name, schema, spec, SortOrder.unsorted(), formatVersion);
5353
}
5454

55-
public static TestTable create(
56-
File temp, String name, Schema schema, Map<String, String> properties, int formatVersion) {
57-
TestTableOperations ops = new TestTableOperations(name, temp);
58-
if (ops.current() != null) {
59-
throw new AlreadyExistsException("Table %s already exists at location: %s", name, temp);
60-
}
61-
62-
ops.commit(
63-
null,
64-
newTableMetadata(
65-
schema,
66-
PartitionSpec.unpartitioned(),
67-
SortOrder.unsorted(),
68-
temp.toString(),
69-
properties,
70-
formatVersion));
71-
72-
return new TestTable(ops, name);
73-
}
74-
7555
public static TestTable create(
7656
File temp,
7757
String name,

data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,14 +211,12 @@ private static DataWriter<StructLike> dataWriter(
211211
return Parquet.writeData(outputFile)
212212
.schema(dataSchema)
213213
.createWriterFunc(InternalWriter::create)
214-
.overwrite()
215214
.withSpec(PartitionSpec.unpartitioned())
216215
.build();
217216
case AVRO:
218217
return Avro.writeData(outputFile)
219218
.schema(dataSchema)
220219
.createWriterFunc(org.apache.iceberg.avro.InternalWriter::create)
221-
.overwrite()
222220
.withSpec(PartitionSpec.unpartitioned())
223221
.build();
224222
case ORC:

0 commit comments

Comments
 (0)