Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve repo linter rules #1487

Open
kevinjqliu opened this issue Jan 5, 2025 · 1 comment
Open

improve repo linter rules #1487

kevinjqliu opened this issue Jan 5, 2025 · 1 comment

Comments

@kevinjqliu
Copy link
Contributor

Feature Request / Improvement

In #1485, we added "UP035" and "UP006" to the linter ignore list. Let's see if we can resolve the underlying issue instead.

Check if we can resolve other ignored linter rules as described in ruff.toml

ignore = ["E501","E203","B024","B028","UP037", "UP035", "UP006"]

And any # type: ignore comments
https://grep.app/search?q=%23%20type%3A%20ignore&filter[repo][0]=apache/iceberg-python

@jayceslesar
Copy link
Contributor

This looks like pretty much every file that uses the old typing imports will need from __future__ import annotations (so almost every file in the repo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants