Skip to content

[Feature Request]: Improvements of File Explorer perspective #5184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gmitter-ef opened this issue Apr 15, 2025 · 6 comments
Open

[Feature Request]: Improvements of File Explorer perspective #5184

gmitter-ef opened this issue Apr 15, 2025 · 6 comments
Assignees
Labels
Hop Gui P3 Nice to have
Milestone

Comments

@gmitter-ef
Copy link

gmitter-ef commented Apr 15, 2025

What would you like to happen?

I would greatly welcome the following improvements of the "File Explorer" perspective in the perspective toolbar:

Remember expanded folders:
When you expand a folder structure, open a pipeline or workflow via double click, you get to the "Data orchestration" perspective. When you want to open another pipeline/workflow by clicking on "File Explorer" again, all the expanded folders from before are collapsed again, and you have to re-expand them again. It would be very convenient if the previously expanded folders would remain expanded when switching back to "File explorer" perspective.

Bring already opened tab to foreground if file is already open:
Double-clicking on CSVs or JSON files in the "File explorer" perspective opens up tabs with the file content. The tab of the most-recently opened file is in the foreground. When you double-click on a file whose tab is ALREADY opened (but in the background), the tab remains in the background. It would be convenient if the tab would be sent to the foreground after double-clicking an already opened file.

Issue Priority

Priority: 3

Issue Component

Component: Hop Gui

@nadment
Copy link
Contributor

nadment commented Apr 15, 2025

For the first point, you can increase the initial depth to load not lazily, so it will remember the expanded folders.
Image

For the second point, I have just submitted a code improvement

nadment added a commit to nadment/hop that referenced this issue Apr 15, 2025
nadment added a commit to nadment/hop that referenced this issue Apr 15, 2025
@nadment nadment self-assigned this Apr 15, 2025
@nadment nadment added this to the 2.14 milestone Apr 15, 2025
nadment added a commit to nadment/hop that referenced this issue Apr 15, 2025
nadment added a commit to nadment/hop that referenced this issue Apr 15, 2025
@gmitter-ef
Copy link
Author

Thank you so much!

@bamaer
Copy link
Contributor

bamaer commented Apr 16, 2025

wouldn't it make sense to set that value to 3 or 5 by default?

@nadment
Copy link
Contributor

nadment commented Apr 16, 2025

I'd prefer the logic to be reversed, with a default value of 999 and a tips in the docs to enable lazy loading if we have a lot of files.

@hansva
Copy link
Contributor

hansva commented Apr 16, 2025

Could we maybe split it between "local" and remote explorer paths?
I think it won't be a problem on a local filesystem to put a high value, but if it's a cloud storage that is being loaded, it could cause a major performance impact.

hansva pushed a commit to nadment/hop that referenced this issue Apr 16, 2025
@nadment
Copy link
Contributor

nadment commented Apr 16, 2025

You're right, I forgot about remote files.

nadment added a commit to nadment/hop that referenced this issue Apr 16, 2025
nadment added a commit to nadment/hop that referenced this issue Apr 16, 2025
Reduce flicker by restoring folders expanded before setRedraw(true)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hop Gui P3 Nice to have
Projects
None yet
Development

No branches or pull requests

4 participants