Skip to content

[Task]: Caching of function names during SQL syntax highlighting #4739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nadment opened this issue Dec 22, 2024 · 4 comments
Open

[Task]: Caching of function names during SQL syntax highlighting #4739

nadment opened this issue Dec 22, 2024 · 4 comments
Assignees
Labels
Hop Gui P3 Nice to have
Milestone

Comments

@nadment
Copy link
Contributor

nadment commented Dec 22, 2024

What needs to happen?

Add function name caching during SQL syntax highlighting, as it takes too long to open dialog boxes.

Issue Priority

Priority: 3

Issue Component

Component: Hop Gui

@xdelox
Copy link
Contributor

xdelox commented Jan 13, 2025

Hi @nadment! I was doing some experiments about this issue, specifically some tries to improve the waiting time when the dialog box of a MS SQL server data source is selected (and MS SQL is not available).
It's very likely that this issue overlaps with the ultimate goal of what I am doing, so if you were planning to take it on, that's absolutely fine, but if not, I'd be happy to handle it.
Let me know what works best for you!

@nadment
Copy link
Contributor Author

nadment commented Jan 13, 2025

You're more than welcome to take charge of this issue.

@xdelox
Copy link
Contributor

xdelox commented Jan 14, 2025

great, thanks! 👍🏻

@xdelox xdelox self-assigned this Jan 14, 2025
@hansva
Copy link
Contributor

hansva commented Jan 27, 2025

I have removed fetching the functions from JDBC driver, it seems to flaky and not trust worthy.
We will use getReservedWords from each DatabaseMeta

@hansva hansva closed this as completed Jan 27, 2025
@hansva hansva added this to the Not Applicable - 2025 milestone Jan 27, 2025
@hansva hansva reopened this Jan 27, 2025
@hansva hansva modified the milestones: Not Applicable - 2025, 2.13 Feb 14, 2025
@hansva hansva removed the task label Mar 12, 2025
@hansva hansva modified the milestones: 2.13, 2.14 Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hop Gui P3 Nice to have
Projects
None yet
Development

No branches or pull requests

3 participants