Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: changing GUI language changes also decimal separator #2814

Open
liosc opened this issue Apr 8, 2023 · 3 comments
Open

[Bug]: changing GUI language changes also decimal separator #2814

liosc opened this issue Apr 8, 2023 · 3 comments
Labels
Milestone

Comments

@liosc
Copy link

liosc commented Apr 8, 2023

Apache Hop version?

2.3.0

Java version?

jdk-11.0.15.10

Operating system

Windows

What happened?

Changing the GUI language changes also the decimal separator. I would like to use English language but I need to use Italian decimal separator. If I choose Italian language a number converted to text appears like 10000,23. If I change the language to English, the same number becomes 1000023.0. I have a very simple pipeline to test this but i didn't find a way to attach it here.
I think GUI language should be independent from international settings.

Issue Priority

Priority: 2

Issue Component

Component: Hop Gui

@github-actions github-actions bot added P2 Default Priority Hop Gui labels Apr 8, 2023
@sramazzina sramazzina changed the title [Bug]: changing GUI language it changes also decimal separator [Bug]: changing GUI language changes also decimal separator Apr 18, 2023
@sramazzina sramazzina added this to the 2.5 milestone Apr 20, 2023
@sramazzina sramazzina removed this from the 2.5 milestone May 17, 2023
@sramazzina sramazzina added this to the 2.6 milestone Jul 5, 2023
@sramazzina sramazzina self-assigned this Jul 5, 2023
@hansva hansva modified the milestones: 2.6, 2.7 Sep 1, 2023
@mattcasters
Copy link
Contributor

Decimal and grouping separators can be specified in most transforms for this specific reason.
Was there a particular place you were missing these options when data conversion is concerned?

@liosc
Copy link
Author

liosc commented Nov 14, 2023

The biggest problem we have with this issue is related to hash generation. Changing decimal and grouping separator produces a different hash so we are forced to use always the same language.
By the way, it doesn't seem logical to me that when you change the language the decimal and grouping separator change too. As I added in the description, I think GUI language should be independent from international settings.

@hansva hansva modified the milestones: 2.7, 2.8 Nov 17, 2023
@sramazzina
Copy link
Contributor

@mattcasters I agree with @liosc. Same as in every operating system were these two aspects are managed separately

@sramazzina sramazzina removed their assignment Nov 20, 2023
@hansva hansva modified the milestones: 2.8, 2.9 Feb 28, 2024
@hansva hansva modified the milestones: 2.9, 2.10 May 20, 2024
@hansva hansva modified the milestones: 2.10, 2.11 Sep 25, 2024
@hansva hansva modified the milestones: 2.11, 2.12 Dec 3, 2024
@hansva hansva modified the milestones: 2.12, 2.13 Jan 31, 2025
@hansva hansva removed the bug label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants