[Improvement][Helm] Refactor configmap control in master #15935
Conversation
|
@Gallardot PTAL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15935 +/- ##
=========================================
Coverage 40.45% 40.46%
+ Complexity 5200 5196 -4
=========================================
Files 1378 1378
Lines 46084 46084
Branches 4922 4923 +1
=========================================
+ Hits 18645 18649 +4
+ Misses 25513 25508 -5
- Partials 1926 1927 +1 ☔ View full report in Codecov by Sentry. |
| - name: config-volume | ||
| mountPath: /opt/dolphinscheduler/conf/common.properties | ||
| subPath: common.properties | ||
| {{- include "dolphinscheduler.etcd.ssl.volumeMount" . | nindent 12 }} |
There was a problem hiding this comment.
it seems this is also needed in api,
so I kept this and adjust the order to make it clear to read.
| @@ -109,11 +109,9 @@ spec: | |||
| volumeMounts: | |||
| - mountPath: "/opt/dolphinscheduler/logs" | |||
| name: {{ include "dolphinscheduler.fullname" . }}-master | |||
| {{- include "dolphinscheduler.sharedStorage.volumeMount" . | nindent 12 }} | |||
There was a problem hiding this comment.
That's fine with me. Why not remove this from api-server as well.
There was a problem hiding this comment.
it seems this config is needed,
I adjust the order and fix some config in worker
pegasas
changed the title
| {{- else }} | ||
| - name: {{ include "dolphinscheduler.fullname" . }}-worker-data | ||
| emptyDir: {} | ||
| - name: {{ include "dolphinscheduler.fullname" . }}-worker-logs | ||
| emptyDir: {} |
There was a problem hiding this comment.
Seems like these lines shouldn't be removed?
There was a problem hiding this comment.
Seems like these lines shouldn't be removed?
+1
| - name: config-volume | ||
| configMap: | ||
| name: {{ include "dolphinscheduler.fullname" . }}-configs | ||
| {{- include "dolphinscheduler.sharedStorage.volume" . | nindent 8 }} |
There was a problem hiding this comment.
Just change from line115 to line 128?
| {{- else }} | ||
| - name: {{ include "dolphinscheduler.fullname" . }}-worker-data | ||
| emptyDir: {} | ||
| - name: {{ include "dolphinscheduler.fullname" . }}-worker-logs | ||
| emptyDir: {} |
There was a problem hiding this comment.
Seems like these lines shouldn't be removed?
+1
|
Purpose of the pull request
fix: #15934
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md