Skip to content

Commit f27900d

Browse files
committed
Review feedback
1 parent 6940f31 commit f27900d

File tree

2 files changed

+1
-15
lines changed

2 files changed

+1
-15
lines changed

newsfragments/47264.significant.rst

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,3 @@ Removed leftover deprecations prior to 3.0.0.
1414
* [ ] Plugin changes
1515
* [ ] Dependency changes
1616
* [x] Code interface changes
17-
18-
19-
dict[str, dict[str, Collection[str]]]
20-
None
21-
22-
!=
23-
24-
dict[str, dict[str, Collection[str]]]
25-
dict[str, Collection[str]]
26-
None

tests/serialization/test_dag_serialization.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -979,11 +979,7 @@ def test_dag_params_roundtrip(self, val, expected_val):
979979

980980
assert "params" in serialized_dag["dag"]
981981

982-
if val and any([True for k, v in val.items() if isinstance(v, set)]):
983-
deserialized_dag = SerializedDAG.from_dict(serialized_dag)
984-
985-
else:
986-
deserialized_dag = SerializedDAG.from_dict(serialized_dag)
982+
deserialized_dag = SerializedDAG.from_dict(serialized_dag)
987983
deserialized_simple_task = deserialized_dag.task_dict["simple_task"]
988984
assert expected_val == deserialized_dag.params.dump()
989985
assert expected_val == deserialized_simple_task.params.dump()

0 commit comments

Comments
 (0)