Skip to content

Commit 48c63f6

Browse files
committed
style: migrate to standard
1 parent 545599b commit 48c63f6

30 files changed

+141
-161
lines changed

.hound.yml

Lines changed: 0 additions & 3 deletions
This file was deleted.

.rubocop.yml

Lines changed: 29 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -1,74 +1,51 @@
1+
require:
2+
- standard/cop/semantic_blocks
3+
- rubocop-md
4+
5+
inherit_gem:
6+
standard: config/base.yml
7+
18
AllCops:
2-
# Include gemspec and Rakefile
3-
Include:
4-
- 'lib/**/*.rb'
5-
- 'lib/**/*.rake'
6-
- 'spec/**/*.rb'
79
Exclude:
8-
- 'bin/**/*'
10+
- 'bin/*'
911
- 'tmp/**/*'
10-
- 'lib/anycable/rpc/**/*'
12+
- 'Gemfile'
1113
- 'vendor/**/*'
1214
- 'gemfiles/**/*'
13-
- 'Gemfile'
14-
- 'Rakefile'
15-
- '*.gemspec'
1615
DisplayCopNames: true
17-
StyleGuideCopsOnly: false
1816
TargetRubyVersion: 2.4
1917

20-
Rails:
18+
Standard/SemanticBlocks:
2119
Enabled: false
2220

23-
Style/Documentation:
24-
Exclude:
25-
- 'spec/**/*.rb'
21+
Style/FrozenStringLiteralComment:
22+
Enabled: true
2623

27-
Style/StringLiterals:
28-
EnforcedStyle: double_quotes
24+
Style/TrailingCommaInArrayLiteral:
25+
EnforcedStyleForMultiline: no_comma
2926

30-
Layout/SpaceInsideStringInterpolation:
31-
EnforcedStyle: no_space
32-
33-
Style/BlockDelimiters:
34-
Exclude:
35-
- 'spec/**/*.rb'
36-
37-
Style/ClassAndModuleChildren:
38-
Exclude:
39-
- 'spec/**/*.rb'
27+
Style/TrailingCommaInHashLiteral:
28+
EnforcedStyleForMultiline: no_comma
4029

41-
Style/ParallelAssignment:
30+
Lint/Void:
4231
Exclude:
43-
- 'spec/**/*.rb'
32+
- '**/*.md'
4433

45-
Metrics/MethodLength:
34+
# See https://github.com/rubocop-hq/rubocop/issues/4222
35+
Lint/AmbiguousBlockAssociation:
4636
Exclude:
47-
- 'spec/**/*.rb'
37+
- 'spec/**/*'
38+
- '**/*.md'
4839

49-
Metrics/LineLength:
50-
Max: 100
40+
Lint/DuplicateMethods:
5141
Exclude:
52-
- 'spec/**/*.rb'
42+
- '**/*.md'
5343

54-
Metrics/AbcSize:
44+
Naming/FileName:
5545
Exclude:
56-
- 'spec/**/*.rb'
46+
- 'lib/anycable-rails.rb'
47+
- '**/*.md'
5748

58-
Metrics/BlockLength:
49+
Layout/InitialIndentation:
5950
Exclude:
60-
- 'spec/**/*.rb'
61-
62-
Metrics/CyclomaticComplexity:
63-
Exclude:
64-
- 'spec/**/*.rb'
65-
66-
Metrics/PerceivedComplexity:
67-
Exclude:
68-
- 'spec/**/*.rb'
69-
70-
Lint/HandleExceptions:
71-
Enabled: false
72-
73-
Naming/RescuedExceptionsVariableName:
74-
Enabled: false
51+
- 'CHANGELOG.md'

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ AnyCable allows you to use custom broadcasting adapters (Redis is used by defaul
8686
```ruby
8787
# Specify by name (tries to load `AnyCable::BroadcastAdapters::MyAdapter` from
8888
# "anycable/broadcast_adapters/my_adapter")
89-
AnyCable.broadcast_adapter = :my_adapter, { option: "value" }
89+
AnyCable.broadcast_adapter = :my_adapter, {option: "value"}
9090
# or provide an instance (should respond_to #broadcast)
9191
AnyCable.broadcast_adapter = MyAdapter.new
9292
```

Gemfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
source 'https://rubygems.org'
22
gemspec
33

4+
gem "pry-byebug", platform: :mri
5+
46
local_gemfile = "#{File.dirname(__FILE__)}/Gemfile.local"
57

68
if File.exist?(local_gemfile)

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ Check out our 📑 [Documentation](https://docs.anycable.io).
5454

5555
```
5656
gem install grpc
57-
gem install grpc-tools
57+
gem install grpc - tools
5858
```
5959

6060
- Re-generate GRPC files (if necessary):

Rakefile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
require "bundler/gem_tasks"
24
require "rspec/core/rake_task"
35
require "rubocop/rake_task"

anycable.gemspec

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
# frozen_string_literal: true
22

3-
lib = File.expand_path('../lib', __FILE__)
3+
lib = File.expand_path("../lib", __FILE__)
44
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
5-
require 'anycable/version'
5+
require "anycable/version"
66

77
Gem::Specification.new do |spec|
8-
spec.name = "anycable"
9-
spec.version = AnyCable::VERSION
10-
spec.authors = ["palkan"]
11-
spec.email = ["[email protected]"]
8+
spec.name = "anycable"
9+
spec.version = AnyCable::VERSION
10+
spec.authors = ["palkan"]
11+
spec.email = ["[email protected]"]
1212

13-
spec.summary = "AnyCable is a polyglot replacement for ActionCable-compatible servers"
14-
spec.description = "AnyCable is a polyglot replacement for ActionCable-compatible servers"
15-
spec.homepage = "http://github.com/anycable/anycable"
16-
spec.license = "MIT"
13+
spec.summary = "AnyCable is a polyglot replacement for ActionCable-compatible servers"
14+
spec.description = "AnyCable is a polyglot replacement for ActionCable-compatible servers"
15+
spec.homepage = "http://github.com/anycable/anycable"
16+
spec.license = "MIT"
1717
spec.metadata = {
1818
"bug_tracker_uri" => "http://github.com/anycable/anycable/issues",
1919
"changelog_uri" => "https://github.com/anycable/anycable/blob/master/CHANGELOG.md",
@@ -22,11 +22,11 @@ Gem::Specification.new do |spec|
2222
"source_code_uri" => "http://github.com/anycable/anycable"
2323
}
2424

25-
spec.executables = %w[anycable anycabled]
26-
spec.files = `git ls-files README.md MIT-LICENSE CHANGELOG.md lib bin`.split
25+
spec.executables = %w[anycable anycabled]
26+
spec.files = `git ls-files README.md MIT-LICENSE CHANGELOG.md lib bin`.split
2727
spec.require_paths = ["lib"]
2828

29-
spec.required_ruby_version = '>= 2.4.0'
29+
spec.required_ruby_version = ">= 2.4.0"
3030

3131
spec.add_dependency "anyway_config", ">= 1.4.2"
3232
spec.add_dependency "grpc", "~> 1.17"
@@ -36,7 +36,7 @@ Gem::Specification.new do |spec|
3636
spec.add_development_dependency "rake", ">= 10.0"
3737
spec.add_development_dependency "rack", "~> 2.0"
3838
spec.add_development_dependency "rspec", ">= 3.5"
39-
spec.add_development_dependency "rubocop", "~> 0.68.0"
39+
spec.add_development_dependency "rubocop-md", "~> 0.3"
4040
spec.add_development_dependency "simplecov", ">= 0.3.8"
41-
spec.add_development_dependency "pry-byebug"
41+
spec.add_development_dependency "standard", "~> 0.1.7"
4242
end

benchmarks/2018-03-04.md

Lines changed: 38 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -124,25 +124,25 @@ Mem: ~1100MB
124124

125125

126126
```
127-
clients: 1000 95per-rtt: 216ms min-rtt: 1ms median-rtt: 17ms max-rtt: 364ms
128-
clients: 2000 95per-rtt: 446ms min-rtt: 0ms median-rtt: 24ms max-rtt: 738ms
129-
clients: 3000 95per-rtt: 348ms min-rtt: 0ms median-rtt: 46ms max-rtt: 925ms
130-
clients: 4000 95per-rtt: 654ms min-rtt: 2ms median-rtt: 65ms max-rtt: 1175ms
131-
clients: 5000 95per-rtt: 590ms min-rtt: 0ms median-rtt: 67ms max-rtt: 1842ms
132-
clients: 6000 95per-rtt: 469ms min-rtt: 1ms median-rtt: 121ms max-rtt: 1098ms
133-
clients: 7000 95per-rtt: 705ms min-rtt: 1ms median-rtt: 121ms max-rtt: 1617ms
134-
clients: 8000 95per-rtt: 1090ms min-rtt: 1ms median-rtt: 159ms max-rtt: 3253ms
135-
clients: 9000 95per-rtt: 869ms min-rtt: 1ms median-rtt: 163ms max-rtt: 3945ms
136-
clients: 10000 95per-rtt: 1171ms min-rtt: 1ms median-rtt: 247ms max-rtt: 2326ms
137-
clients: 11000 95per-rtt: 1634ms min-rtt: 1ms median-rtt: 191ms max-rtt: 4383ms
138-
clients: 12000 95per-rtt: 1138ms min-rtt: 2ms median-rtt: 283ms max-rtt: 8319ms
139-
clients: 13000 95per-rtt: 1234ms min-rtt: 1ms median-rtt: 306ms max-rtt: 5429ms
140-
clients: 14000 95per-rtt: 947ms min-rtt: 1ms median-rtt: 346ms max-rtt: 7804ms
141-
clients: 15000 95per-rtt: 1716ms min-rtt: 1ms median-rtt: 344ms max-rtt: 7372ms
142-
clients: 16000 95per-rtt: 1999ms min-rtt: 1ms median-rtt: 364ms max-rtt: 3047ms
143-
clients: 17000 95per-rtt: 1729ms min-rtt: 1ms median-rtt: 410ms max-rtt: 7231ms
144-
clients: 18000 95per-rtt: 1455ms min-rtt: 1ms median-rtt: 442ms max-rtt: 4725ms
145-
clients: 19000 95per-rtt: 2006ms min-rtt: 1ms median-rtt: 456ms max-rtt: 3811ms
127+
clients: 1000 95per-rtt: 216ms min-rtt: 1ms median-rtt: 17ms max-rtt: 364ms
128+
clients: 2000 95per-rtt: 446ms min-rtt: 0ms median-rtt: 24ms max-rtt: 738ms
129+
clients: 3000 95per-rtt: 348ms min-rtt: 0ms median-rtt: 46ms max-rtt: 925ms
130+
clients: 4000 95per-rtt: 654ms min-rtt: 2ms median-rtt: 65ms max-rtt: 1175ms
131+
clients: 5000 95per-rtt: 590ms min-rtt: 0ms median-rtt: 67ms max-rtt: 1842ms
132+
clients: 6000 95per-rtt: 469ms min-rtt: 1ms median-rtt: 121ms max-rtt: 1098ms
133+
clients: 7000 95per-rtt: 705ms min-rtt: 1ms median-rtt: 121ms max-rtt: 1617ms
134+
clients: 8000 95per-rtt: 1090ms min-rtt: 1ms median-rtt: 159ms max-rtt: 3253ms
135+
clients: 9000 95per-rtt: 869ms min-rtt: 1ms median-rtt: 163ms max-rtt: 3945ms
136+
clients: 10000 95per-rtt: 1171ms min-rtt: 1ms median-rtt: 247ms max-rtt: 2326ms
137+
clients: 11000 95per-rtt: 1634ms min-rtt: 1ms median-rtt: 191ms max-rtt: 4383ms
138+
clients: 12000 95per-rtt: 1138ms min-rtt: 2ms median-rtt: 283ms max-rtt: 8319ms
139+
clients: 13000 95per-rtt: 1234ms min-rtt: 1ms median-rtt: 306ms max-rtt: 5429ms
140+
clients: 14000 95per-rtt: 947ms min-rtt: 1ms median-rtt: 346ms max-rtt: 7804ms
141+
clients: 15000 95per-rtt: 1716ms min-rtt: 1ms median-rtt: 344ms max-rtt: 7372ms
142+
clients: 16000 95per-rtt: 1999ms min-rtt: 1ms median-rtt: 364ms max-rtt: 3047ms
143+
clients: 17000 95per-rtt: 1729ms min-rtt: 1ms median-rtt: 410ms max-rtt: 7231ms
144+
clients: 18000 95per-rtt: 1455ms min-rtt: 1ms median-rtt: 442ms max-rtt: 4725ms
145+
clients: 19000 95per-rtt: 2006ms min-rtt: 1ms median-rtt: 456ms max-rtt: 3811ms
146146
clients: 20000 95per-rtt: 2923ms min-rtt: 1ms median-rtt: 378ms max-rtt: 11954ms
147147
148148
Missing received broadcasts: expected 23100000, got 23089387
@@ -155,25 +155,25 @@ CPU (avg): ~4%
155155
Mem: ~1000MB
156156

157157
```
158-
clients: 1000 95per-rtt: 173ms min-rtt: 2ms median-rtt: 21ms max-rtt: 617ms
159-
clients: 2000 95per-rtt: 311ms min-rtt: 2ms median-rtt: 39ms max-rtt: 594ms
160-
clients: 3000 95per-rtt: 386ms min-rtt: 3ms median-rtt: 91ms max-rtt: 592ms
161-
clients: 4000 95per-rtt: 539ms min-rtt: 2ms median-rtt: 93ms max-rtt: 973ms
162-
clients: 5000 95per-rtt: 534ms min-rtt: 2ms median-rtt: 128ms max-rtt: 1486ms
163-
clients: 6000 95per-rtt: 1092ms min-rtt: 2ms median-rtt: 110ms max-rtt: 3073ms
164-
clients: 7000 95per-rtt: 726ms min-rtt: 3ms median-rtt: 185ms max-rtt: 1116ms
165-
clients: 8000 95per-rtt: 1078ms min-rtt: 2ms median-rtt: 174ms max-rtt: 3296ms
166-
clients: 9000 95per-rtt: 1401ms min-rtt: 8ms median-rtt: 195ms max-rtt: 6838ms
167-
clients: 10000 95per-rtt: 1157ms min-rtt: 3ms median-rtt: 282ms max-rtt: 3446ms
168-
clients: 11000 95per-rtt: 1804ms min-rtt: 4ms median-rtt: 271ms max-rtt: 5640ms
169-
clients: 12000 95per-rtt: 1339ms min-rtt: 2ms median-rtt: 344ms max-rtt: 2251ms
170-
clients: 13000 95per-rtt: 1638ms min-rtt: 3ms median-rtt: 336ms max-rtt: 3341ms
171-
clients: 14000 95per-rtt: 1811ms min-rtt: 3ms median-rtt: 339ms max-rtt: 2079ms
172-
clients: 15000 95per-rtt: 1407ms min-rtt: 2ms median-rtt: 435ms max-rtt: 6666ms
173-
clients: 16000 95per-rtt: 2796ms min-rtt: 2ms median-rtt: 398ms max-rtt: 4769ms
174-
clients: 17000 95per-rtt: 2494ms min-rtt: 6ms median-rtt: 338ms max-rtt: 36085ms
175-
clients: 18000 95per-rtt: 2844ms min-rtt: 2ms median-rtt: 374ms max-rtt: 7384ms
176-
clients: 19000 95per-rtt: 4010ms min-rtt: 17ms median-rtt: 370ms max-rtt: 5504ms
158+
clients: 1000 95per-rtt: 173ms min-rtt: 2ms median-rtt: 21ms max-rtt: 617ms
159+
clients: 2000 95per-rtt: 311ms min-rtt: 2ms median-rtt: 39ms max-rtt: 594ms
160+
clients: 3000 95per-rtt: 386ms min-rtt: 3ms median-rtt: 91ms max-rtt: 592ms
161+
clients: 4000 95per-rtt: 539ms min-rtt: 2ms median-rtt: 93ms max-rtt: 973ms
162+
clients: 5000 95per-rtt: 534ms min-rtt: 2ms median-rtt: 128ms max-rtt: 1486ms
163+
clients: 6000 95per-rtt: 1092ms min-rtt: 2ms median-rtt: 110ms max-rtt: 3073ms
164+
clients: 7000 95per-rtt: 726ms min-rtt: 3ms median-rtt: 185ms max-rtt: 1116ms
165+
clients: 8000 95per-rtt: 1078ms min-rtt: 2ms median-rtt: 174ms max-rtt: 3296ms
166+
clients: 9000 95per-rtt: 1401ms min-rtt: 8ms median-rtt: 195ms max-rtt: 6838ms
167+
clients: 10000 95per-rtt: 1157ms min-rtt: 3ms median-rtt: 282ms max-rtt: 3446ms
168+
clients: 11000 95per-rtt: 1804ms min-rtt: 4ms median-rtt: 271ms max-rtt: 5640ms
169+
clients: 12000 95per-rtt: 1339ms min-rtt: 2ms median-rtt: 344ms max-rtt: 2251ms
170+
clients: 13000 95per-rtt: 1638ms min-rtt: 3ms median-rtt: 336ms max-rtt: 3341ms
171+
clients: 14000 95per-rtt: 1811ms min-rtt: 3ms median-rtt: 339ms max-rtt: 2079ms
172+
clients: 15000 95per-rtt: 1407ms min-rtt: 2ms median-rtt: 435ms max-rtt: 6666ms
173+
clients: 16000 95per-rtt: 2796ms min-rtt: 2ms median-rtt: 398ms max-rtt: 4769ms
174+
clients: 17000 95per-rtt: 2494ms min-rtt: 6ms median-rtt: 338ms max-rtt: 36085ms
175+
clients: 18000 95per-rtt: 2844ms min-rtt: 2ms median-rtt: 374ms max-rtt: 7384ms
176+
clients: 19000 95per-rtt: 4010ms min-rtt: 17ms median-rtt: 370ms max-rtt: 5504ms
177177
clients: 20000 95per-rtt: 2819ms min-rtt: 2ms median-rtt: 470ms max-rtt: 8598ms
178178
179179
Missing received broadcasts: expected 23100000, got 23065521

benchmarks/2018-05-27-rpc-bench.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ The purpose of this benchmark is to measure the thoughout of RPC connection betw
1616
**NOTE 2:** "Noop RPC" is just a gRPC handling doing nothing except from responding with success result.
1717

1818
Sources:
19-
- [Golang](https://github.com/anycable/anycable-go/blob/chore/benchmarking/cmd/rpc-bench/main.go)
19+
- [Golang](https://github.com/anycable/anycable-go/blob/chore/benchmarking/cmd/rpc-bench/main.go)
2020
- [Erlang](https://github.com/anycable/simple-cable-app/tree/master/benchmarks)
2121

2222
## Erlang single connection

circle.yml

Lines changed: 0 additions & 8 deletions
This file was deleted.

0 commit comments

Comments
 (0)