Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithm/function to update the leaf nodes in the MerkleTree #26

Open
AlvinKuruvilla opened this issue Apr 18, 2023 · 3 comments
Open

Comments

@AlvinKuruvilla
Copy link

First off I want to thank you for making this crate. I had one potential suggestion to improve the crate. I feel that it would be useful to have a helper function that enables a leaf node in a given tree to be updated. I tried looking in the documentation to see if such functionality already existed but I couldn't find anything.
My current workaround for this issue is to update the set of leaves and create an entirely new MerkleTree from there, however, this is very wasteful especially when dealing with large leaf counts.
Do you have any suggestions for a better way to do something like this, or if a function could be designed to do this?

@AlvinKuruvilla AlvinKuruvilla changed the title Algorithm.function to update the leaf nodes in the MerkleTree Algorithm/function to update the leaf nodes in the MerkleTree Apr 18, 2023
@antouhou
Copy link
Owner

antouhou commented May 2, 2023

Hey @AlvinKuruvilla ! Yeah, I was thinking about something like this, just never had the time to add such functionality. I have somewhat limited availability right now, but would look into it a bit later, thanks!

@AlvinKuruvilla
Copy link
Author

Of course, thanks for getting back to me. If you could give me some direction on how you would go about implementing a feature like this, I could try writing a PR for it

@Pompey21
Copy link

+1: having this feature would be absolutely amazing!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants