Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github version is not the same as the one on rubygems #7

Open
hossameldeen opened this issue Feb 26, 2019 · 2 comments
Open

Github version is not the same as the one on rubygems #7

hossameldeen opened this issue Feb 26, 2019 · 2 comments

Comments

@hossameldeen
Copy link

The rubygems version seems to have been last updated in 2014, while there's a fix merged (#6) on Github in late 2017. Haven't really tested out either version so don't know if this is actually a problem.

To future readers: If this is indeed a problem and until it's fixed, I think this a temp workaround is just to get it directly from the git repo:

gem 'omniauth-gumroad', git: 'https://github.com/gumroad/omniauth-gumroad'

Note that this workaround has a caveat related to gem list. Read the linked page.

@slavingia
Copy link
Contributor

great! feel free to upgrade and submit a pr

@hossameldeen
Copy link
Author

Ummm ... I think you've misunderstood me: I meant that the version of omniauth-gumroad uploaded on rubygems is old and doesn't have this fix (#6) that has been merged on Github. Not that omniauth-gumroad uses an old version of another package.

So, the steps to fix that, I guess:

Note: I was going to use omniauth-gumroad but I ended up not needing to at the moment, so the issue is not urgent for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants