Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Newtonsoft.Json to System.Text.Json #33

Open
anthonyreilly opened this issue Feb 11, 2021 · 4 comments
Open

Migrate from Newtonsoft.Json to System.Text.Json #33

anthonyreilly opened this issue Feb 11, 2021 · 4 comments

Comments

@anthonyreilly
Copy link
Owner

Newtonsoft.Json is effectively a legacy library, now that .NET has updated it's native JSON support, migration for performance and support reasons would probably be a good idea.

https://docs.microsoft.com/en-us/dotnet/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to?pivots=dotnet-core-3-1

@anthonyreilly
Copy link
Owner Author

Currently no direct replacement for DefaultContractResolver, may need custom implementation
dotnet/runtime#31257

@jmbryan4
Copy link

any update on this now that System.Text.Json has more features? Custom Contracts can be defined.
https://learn.microsoft.com/en-us/dotnet/standard/serialization/system-text-json/custom-contracts

@anthonyreilly
Copy link
Owner Author

Thanks for the link - I was waiting for something like that to be added. I'll check it out and see if it will work - I've wanted to migrate away from the old JSON library for a while now.

@TonyValenti
Copy link

Hi @anthonyreilly -
Do you think you can get this implemented now that .NET 8.0 is out?

By the way, thank you so much for your work with this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants