Skip to content

Configuration file settings do not take effect #95

@duowb

Description

@duowb

This is my script

"scripts": {
   "release": "bumpp",
}

This is my configuration file, confirm does not take effect.

// bump.config.ts
import { defineConfig } from 'bumpp'
export default defineConfig({
    confirm: false
})

The reason is that L32 overwrites the settings in the configuration file.

I don't understand why the values ​​in the configuration file are overwritten with default values ​​here. We have set the default values ​​here in L30.

Temporary solution:

bumpp -y

Solution:

L40

- confirm: !args.yes,
+ confirm: typeof args.yes === 'boolean' ? !args.yes : undefined,
- noVerify: !args.verify,
+ noVerify: typeof args.verify === 'boolean' ? !args.verify : undefined,
- install: args.install,
+ install: typeof args.install ===  'boolean' ? args.install : undefined,

Reproduction

no

System Info

System:
    OS: Windows 11 10.0.26100
    CPU: (12) x64 12th Gen Intel(R) Core(TM) i7-1255U
    Memory: 3.12 GB / 15.68 GB
  Binaries:
    Node: 18.20.5 - ~\AppData\Local\Volta\tools\image\node\18.20.5\node.EXE
    Yarn: 4.1.1 - ~\AppData\Local\Volta\tools\image\yarn\4.1.1\bin\yarn.CMD
    npm: 10.8.2 - ~\AppData\Local\Volta\tools\image\node\18.20.5\npm.CMD
    pnpm: 10.14.0 - ~\AppData\Local\Volta\tools\image\pnpm\10.8.1\bin\pnpm.CMD
  Browsers:
    Edge: Chromium (139.0.3405.111)
    Internet Explorer: 11.0.26100.1882

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.

Contributions

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions