Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle new token types and PHP parser enhancements #104

Open
antecedent opened this issue Aug 14, 2021 · 1 comment
Open

Handle new token types and PHP parser enhancements #104

antecedent opened this issue Aug 14, 2021 · 1 comment

Comments

@antecedent
Copy link
Owner

This entails, first and foremost, dealing with the T_NAME_* trio of PHP 8:

  • T_NAME_FULLY_QUALIFIED,
  • T_NAME_QUALIFIED,
  • T_NAME_RELATIVE.

The preceding is a priority, because there are places where Patchwork scans relative names and resolves them into qualified names. And as of v2.1.12, it still assumes that the names are made of T_STRING and T_NS_SEPARATOR only.

After that, there are attributes, and there is fn, and perhaps there is something else that I cannot recall for the time being. Some new test cases are due to verify that neither of these tokens will interfere with Patchwork's parser.

Also, somewhat tangentially, we should make sure that Patchwork plays nice with the syntax enhancements that came PHP 7. Some precedences changed; some new compositions of preexisting syntactic constructs became possible.

@antecedent
Copy link
Owner Author

The T_NAME_* part is now fixed. Not closing since this issue originally subsumes extending the test suite too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant