Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support diff mode in awx.awx.* modules #14903

Open
4 of 9 tasks
keilr opened this issue Feb 20, 2024 · 2 comments · May be fixed by #15118
Open
4 of 9 tasks

Support diff mode in awx.awx.* modules #14903

keilr opened this issue Feb 20, 2024 · 2 comments · May be fixed by #15118
Labels
community component:awx_collection issues related to the collection for controlling AWX type:enhancement

Comments

@keilr
Copy link

keilr commented Feb 20, 2024 •
edited

Please confirm the following

  • I agree to follow this project's code of conduct.
  • I have checked the current issues for duplicates.
  • I understand that AWX is open source software provided for free and that I might not receive a timely response.

Feature type

New Feature

Feature Summary

During the playbook development process, we heavily use the --check and --diff modes to verify what will be changed on the controller before applying the configuration. However, as the awx.awx.* modules do not yet support the diff mode, the playbook output is not helpful during a dry run.

Select the relevant components

  • UI
  • API
  • Docs
  • Collection
  • CLI
  • Other

Steps to reproduce

n/a

Current results

n/a

Sugested feature result

show diff output

Additional information

We use infra.controller_configuration collection to configure all AWX resources (GitOps). Therefore, a dry run with proper diff output would be very helpful in detecting issues that may potentially destroy the entire AWX instance.
@github-actions github-actions bot added component:awx_collection issues related to the collection for controlling AWX needs_triage type:enhancement community labels Feb 20, 2024
This was referenced Apr 19, 2024
Open
Open
@fosterseth
Copy link
Member

@sean-m-sullivan do have some opinions on diff mode support? I realize check mode probably doesn't work very well across all awx modules, but diff (without check) probably has a better chance of being consistent and useful

@sean-m-sullivan
Copy link
Contributor

I think a diff mode might be possible by reading the the api and determining if there is a change, and could be useful as well. it depends on how we want to do it, but could compare new fields to existing fields dict where they match in most modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community component:awx_collection issues related to the collection for controlling AWX type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add diff mode support to ansible modules keilr/awx
3 participants
@fosterseth @keilr @sean-m-sullivan