Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unescaped label values in URL #477

Open
bendem opened this issue Jan 31, 2023 · 1 comment
Open

Unescaped label values in URL #477

bendem opened this issue Jan 31, 2023 · 1 comment
Labels
bug UI Related to the built-in user interface

Comments

@bendem
Copy link

bendem commented Jan 31, 2023

What is the issue ?

The default subset label created when a play is limited via --limit can contain ampersands, which means, when clicking on the label, we always get an empty result due to part of the label value being interpreted as another parameter.

Example: ?label=subset:vault,&staging

What should be happening ?

& should be escaped to ?label=subset:vault,%26staging (the decoding works fine, if I fix the URL manually, I get the expected result).

@dmsimard dmsimard added the bug label Feb 8, 2023
@dmsimard
Copy link
Contributor

dmsimard commented Feb 8, 2023

Hi @bendem and thanks for the issue !

This looks like a legit bug so I will leave this issue opened so we can fix it eventually.

@dmsimard dmsimard added the UI Related to the built-in user interface label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug UI Related to the built-in user interface
Projects
None yet
Development

No branches or pull requests

2 participants