Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issue between ara client version 1.6.0 and ara server version 1.5.8 #467

Open
hille721 opened this issue Dec 7, 2022 · 1 comment
Labels
compatibility and upgrades Related to forward/backwards compatibility and upgrades docs Related to the documentation enhancement

Comments

@hille721
Copy link
Contributor

hille721 commented Dec 7, 2022

During an automic update of one ara client I recognized a compatibility issue between ara client version 1.6.0 and ara server 1.5.8. The playbook get's created in ara, but updating fails:

...
[WARNING]: Failure using method (v2_playbook_on_task_start) in callback plugin (<ansible.plugins.callback.ara_default.CallbackModule object at 0x7f3cafeb1610>): 'uuid'
Callback Exception: 
  File "/home/hille/gitrepos/plminfra_ansible/.venv/lib/python3.9/site-packages/ansible/executor/task_queue_manager.py", line 450, in send_callback
    method(*new_args, **kwargs)
   File "/home/hille/gitrepos/plminfra_ansible/.venv/lib/python3.9/site-packages/ara/plugins/callback/ara_default.py", line 504, in v2_playbook_on_task_start
    self._end_task()
   File "/home/hille/gitrepos/plminfra_ansible/.venv/lib/python3.9/site-packages/ara/plugins/callback/ara_default.py", line 602, in _end_task
    task_uuid = self.task["uuid"]
...

[WARNING]: Failure using method (v2_runner_on_ok) in callback plugin (<ansible.plugins.callback.ara_default.CallbackModule object at 0x7f3cafeb1610>): 'NoneType' object has no attribute 'submit'
Callback Exception: 
  File "/home/hille/gitrepos/plminfra_ansible/.venv/lib/python3.9/site-packages/ansible/executor/task_queue_manager.py", line 450, in send_callback
    method(*new_args, **kwargs)
   File "/home/hille/gitrepos/plminfra_ansible/.venv/lib/python3.9/site-packages/ara/plugins/callback/ara_default.py", line 534, in v2_runner_on_ok
    self._submit_thread("task", self._load_result, result, "ok", **kwargs)
   File "/home/hille/gitrepos/plminfra_ansible/.venv/lib/python3.9/site-packages/ara/plugins/callback/ara_default.py", line 359, in _submit_thread
    threads.submit(func, *args, **kwargs)
...

[WARNING]: Failure using method (v2_playbook_on_stats) in callback plugin (<ansible.plugins.callback.ara_default.CallbackModule object at 0x7f3cafeb1610>): 'uuid'
Callback Exception: 
  File "/home/hille/gitrepos/plminfra_ansible/.venv/lib/python3.9/site-packages/ansible/executor/task_queue_manager.py", line 450, in send_callback
    method(*new_args, **kwargs)
   File "/home/hille/gitrepos/plminfra_ansible/.venv/lib/python3.9/site-packages/ara/plugins/callback/ara_default.py", line 586, in v2_playbook_on_stats
    self._end_task()
   File "/home/hille/gitrepos/plminfra_ansible/.venv/lib/python3.9/site-packages/ara/plugins/callback/ara_default.py", line 602, in _end_task
    task_uuid = self.task["uuid"]

In ara the playbook will be then shown forever as running.

Good thing is, running ara server 1.6.0 and ara client 1.5.8 is working without any problems (of course some things introduced with 1.6.0 are then n/a in the GUI:
image

This issues should be more a tip for everyone, that the upgrade path to 1.6.0 should be:

  1. upgrade server
  2. upgrade all your clients

This ensures that ara is still working also in a transition phase.

@dmsimard : maybe you could also announce this somewhere.

@dmsimard
Copy link
Contributor

dmsimard commented Dec 8, 2022

@hille721 thanks for the issue, the explanation makes sense.

There is a mention of it in the upgrade notes:
Screenshot from 2022-12-08 00-06-32

We can do better next time, we don't currently have integration tests for forward and backwards compat but I could see that being useful.

I will leave this issue open for now.

@dmsimard dmsimard added docs Related to the documentation enhancement compatibility and upgrades Related to forward/backwards compatibility and upgrades labels Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility and upgrades Related to forward/backwards compatibility and upgrades docs Related to the documentation enhancement
Projects
None yet
Development

No branches or pull requests

2 participants