-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to text when json is not supported #747
Comments
@xibriz Thank you for reporting this. Do you mean that your target device does not support any form of Also, please note that the chassis and NX-OS combination you shared is not a part of our platform support matrix and hence, fixing this issue will be on a best effort basis. Thank you. |
@NilashishC Yes, that is correct, see the output below. You know the collection best, but I (and probably others) would be happy with a more robust solution of my fix, or some kind of option in the facts module to force text output in stead of json. Since the rest of the code handles text output as well as json, this should be possible without breaking anything?
|
Considering the substantial effort involved and the fact that NX-OS versions lacking support for | json fall outside our current support scope, we've made the decision not to pursue this implementation. However, we strongly encourage contributions from the community! If anyone is enthusiastic about tackling this challenge, we'd be delighted to accept and review their contributions. As such, I've added the Thank you! |
I have a Nexus 5596 with NXOS 7.0(2)N1(1)
When trying to gather facts
ansible_net_interfaces
does not get populated correctly.Further investigating shows that the command
show interface | json-pretty
is not supported. The device does not have any json capabilities.It seems like some sort of text fallback is missing in the run-function.
cisco.nxos/plugins/module_utils/network/nxos/facts/legacy/base.py
Lines 39 to 65 in 005a400
I have temporarly solved the problem by adding the following code:
The text was updated successfully, but these errors were encountered: