Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanning tree #817

Open
wants to merge 47 commits into
base: main
Choose a base branch
from

Conversation

tnizharadze
Copy link

SUMMARY

This pull request adds support for spanning-tree in global configuration mode

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

cisco.ios.ios_spanning_tree

ADDITIONAL INFORMATION

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/55ac85f5a3ad4fd3a81505f7b76e2a25

✔️ ansible-galaxy-importer SUCCESS in 4m 41s
✔️ build-ansible-collection SUCCESS in 8m 51s
ansible-ee-integration-ios-latest FAILURE in 14m 57s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 22m 02s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 20m 37s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 15m 15s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 45m 05s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 41m 11s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 44m 57s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 43m 06s (non-voting)
ansible-tox-linters FAILURE in 11m 23s

@Qalthos Qalthos added the feature This issue/PR relates to a feature request. label Apr 26, 2023
@Qalthos Qalthos requested a review from KB-perByte April 26, 2023 13:10
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d1cba2c098094c8e802fae0f45daf33f

✔️ ansible-galaxy-importer SUCCESS in 4m 17s
✔️ build-ansible-collection SUCCESS in 8m 51s
ansible-ee-integration-ios-latest FAILURE in 15m 46s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 16m 15s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 16m 04s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 16m 29s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 44m 44s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 42m 44s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 45m 51s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 46m 12s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 43s

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/00c042f30cdd4f4dbacd2e310f5326ff

✔️ ansible-galaxy-importer SUCCESS in 5m 35s
✔️ build-ansible-collection SUCCESS in 8m 59s
ansible-ee-integration-ios-latest FAILURE in 19m 31s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 17m 02s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 16m 38s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 16m 58s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 44m 41s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 39m 16s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 44m 12s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 44m 15s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 51s

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0d35ec429ccc4731b5d7c0256381726b

✔️ ansible-galaxy-importer SUCCESS in 3m 47s
✔️ build-ansible-collection SUCCESS in 8m 42s
ansible-ee-integration-ios-latest FAILURE in 18m 04s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 17m 44s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 18m 08s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 18m 00s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 43m 58s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 39m 25s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 42m 42s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 42m 28s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 28s

@KB-perByte
Copy link
Collaborator

Hey @tnizharadze Thank you for your contribution, Could you please add unit test cases ( ~80% coverage ) and integration tests for the module you have added?
Note - we try to keep the models similar to other network collections present, we would hold the PR until other collections can check and get a model ready. I'll share updates about it shortly.
Thank you and sorry for the delayed response.

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ae91f7dc9fec4ef09cb910eb5f6cbfb3

✔️ ansible-galaxy-importer SUCCESS in 4m 00s
✔️ build-ansible-collection SUCCESS in 9m 06s
ansible-ee-integration-ios-latest FAILURE in 18m 27s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 1h 11m 44s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 18m 13s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 20m 29s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 46m 12s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 45m 11s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 48m 13s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 44m 20s (non-voting)
✔️ ansible-tox-linters SUCCESS in 14m 46s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/93817549b78b4af19daf803aa52eb004

✔️ ansible-galaxy-importer SUCCESS in 3m 55s
✔️ build-ansible-collection SUCCESS in 9m 43s
ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 38s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 15m 04s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 40s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 14s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 11s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 48s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 41s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 29s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 25s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/fec694b76952449db9a81bd3a0be8141

✔️ ansible-galaxy-importer SUCCESS in 4m 15s
✔️ build-ansible-collection SUCCESS in 9m 40s
ansible-ee-integration-ios-latest RETRY_LIMIT in 4m 08s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 56s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 37s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 11s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 11s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 15m 46s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 4m 06s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 41s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 23s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/17f7a03caa1a4c5a9b50e673342cb276

✔️ ansible-galaxy-importer SUCCESS in 4m 50s
✔️ build-ansible-collection SUCCESS in 9m 41s
ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 19s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 18m 36s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 19s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 56s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 37s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 16m 15s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 4m 19s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 57s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 28s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/f410ac5fc0dc4c4caa83869506733aa0

✔️ ansible-galaxy-importer SUCCESS in 5m 07s
✔️ build-ansible-collection SUCCESS in 9m 39s
ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 20s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 33s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 22s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 26s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 15s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 09s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 42s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 24s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 34s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/babeb348ffb04925bc5e169afb5ce980

✔️ ansible-galaxy-importer SUCCESS in 4m 43s
✔️ build-ansible-collection SUCCESS in 10m 00s
ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 30s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 15m 26s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 49s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 51s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 20s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 26s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 50s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 25s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 36s

@v-moro
Copy link

v-moro commented Feb 14, 2024

Hi all,
I'm keeping my fingers crossed that this PR is merged! Without that, the most basic Ansible playbook for a switch config is incomplete for our use case.
Thank you for your hard work here.

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/cb2f8d643ba044c0a3e82f59b66680fa

✔️ ansible-galaxy-importer SUCCESS in 4m 48s
✔️ build-ansible-collection SUCCESS in 9m 51s
ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 16s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 11m 58s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 10s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 16s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 15s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 12m 27s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 2m 53s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 15s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 46s

@TafkaMax
Copy link

TafkaMax commented Jun 8, 2024

So how is this going, when will it be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to the existing code feature This issue/PR relates to a feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support of basic Spanning-Tree configurations
7 participants