Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate RGL viewer (instead of pop-up) #2

Closed
annakrystalli opened this issue Jan 7, 2022 · 2 comments
Closed

Integrate RGL viewer (instead of pop-up) #2

annakrystalli opened this issue Jan 7, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@annakrystalli
Copy link
Owner

No description provided.

@annakrystalli
Copy link
Owner Author

Done but slow. See dmurdoch/rgl#4

Options:

@annakrystalli annakrystalli added the enhancement New feature or request label Jan 31, 2022
annakrystalli added a commit that referenced this issue Feb 7, 2022
compile all vertices and render segments once per beak. Resolves #2
@annakrystalli
Copy link
Owner Author

So! In the end there was a much simpler fix to the problem! Due to some data reshaping required before plotting each beak, the original code was extracting and rendering each segment of each beak (75 for each) individually in a for loop, effectively running the most expensive function 75 times per beak.

Can't believe I missed that! 🙈 . In any case I know all the beak coordinates first and then render the whole beak in a single segments3d, and it's as fast as! No fancy methods required! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant