Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to List Users API the ability to filter users by skills #759

Open
5 tasks
paritoshsinghrahar opened this issue Aug 27, 2020 · 38 comments · May be fixed by #1097
Open
5 tasks

Add to List Users API the ability to filter users by skills #759

paritoshsinghrahar opened this issue Aug 27, 2020 · 38 comments · May be fixed by #1097
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug.

Comments

@paritoshsinghrahar
Copy link

paritoshsinghrahar commented Aug 27, 2020

Description

As a member of the app,
I need be able to filter other members by their skills,
so that I can choose the member I want to create a mentorship relation with.

APIs used to fetch Users, don't have an option to filter users by skills attribute.

Note: This issue is labeled for Open Source Hack.

I can assign this issue to you on September 1st as the official opening date for Open Source Hack. Please free to check out other issues in the meantime. Program website: https://anitab-org.github.io/events/open-source-hack/

Acceptance Criteria

Update [Required]

  • Add a query parameter support to GET /users and GET /users/verified, to filter users by skills attribute.
  • Update Swagger UI documentation for this API.
  • Write at least one test to prove your new feature is working.

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

[4] hours

@paritoshsinghrahar paritoshsinghrahar added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Open Source Hack Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Aug 27, 2020
@ashokrayal
Copy link
Contributor

Hi,

I want to work on this one. please assign it to me.

@paritoshsinghrahar
Copy link
Author

@ashokrayal Another issue has been assigned to you. Please complete that and check back.

@Manav-03
Copy link

Manav-03 commented Sep 2, 2020

Hi @paritoshsinghrahar,
I'd like to work on this issue for OSH, could you please assign it to me?

@paritoshsinghrahar
Copy link
Author

@Manav-03 I have assigned you. I hope you have set up the environment and read community guidelines.

Happy Coding. 😃

@Manav-03
Copy link

Manav-03 commented Sep 3, 2020

@paritoshsinghrahar Thank you, I'll get to it right away. :)

@vj-codes
Copy link
Member

vj-codes commented Sep 7, 2020

@Manav-03 how's the PR going?

@Manav-03
Copy link

Manav-03 commented Sep 7, 2020

@vj-codes I had some trouble setting the environment up but I'm working on it right now :)

@vj-codes
Copy link
Member

vj-codes commented Sep 7, 2020

@Manav-03 if the errors are solved, share them here or on zulip, we could help you then:)

@Manav-03
Copy link

Manav-03 commented Sep 7, 2020

@vj-codes I set up the environment and installed the requirements. However, when I tried to run 'run.py' it gave me some errors about not having the module pysqlite. I tried to install pysqlite but it didn't work as python 3 does not support pysqlite, it said that that I should install pysqlite3 instead, which I did, but it hasn't helped.

@vj-codes
Copy link
Member

vj-codes commented Sep 7, 2020

@Manav-03 please can you provide screenshot of - error and your .env file

@Manav-03
Copy link

Manav-03 commented Sep 7, 2020

@vj-codes
image - error
image - .env

@vj-codes
Copy link
Member

vj-codes commented Sep 7, 2020

@Manav-03 secret_key should be different from security_password_salt , either update any one to 12345
Then , mail_default_sender should be an actual email like [email protected]
If you are using gmail above then , mail_server is smtp.mail.com , if using something else search and adapt the mail_server accordingly
app_mail_username should be username used in above mail address like in this case it is myname

Mostly the error was due to the .env file , update what I mentioned above and see if it runs

@vj-codes
Copy link
Member

vj-codes commented Sep 7, 2020

@Manav-03 remove the current virtual environment and name it as venv only coz the code uses venv and may cause more errors

@Manav-03
Copy link

Manav-03 commented Sep 7, 2020

@vj-codes
image

I made these changed to .env and the problem still persists. Should I delete the virtual environment I created and create another one with the name venv?

@vj-codes
Copy link
Member

vj-codes commented Sep 7, 2020

@Manav-03 I would say yes
Also do this command
pip install python-dotenv before python run.py

@pallavisavant
Copy link
Contributor

Is this still available if yes then can i take this up ..Thanks.

@vj-codes vj-codes removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Sep 8, 2020
@Manav-03
Copy link

Manav-03 commented Sep 9, 2020

@pallavisavant The issue is assigned to me. I've had some issues on my system while working on it, due to which I've been slowed down. If I can't figure it out in a few more days I will unassign myself.

@pallavisavant
Copy link
Contributor

@Manav-03 ok no issues....Thanks.

@vj-codes
Copy link
Member

vj-codes commented Sep 9, 2020

@Manav-03 what do you see on your localhost now?

@Manav-03
Copy link

Manav-03 commented Sep 9, 2020

@vj-codes Ever since I removed the environment that I first created to make another one with the appropriate name my terminal is not even recognizing 'Python', I tried to add it to the PATH variable but I'm still facing issues. I'll figure out the issues in my system ASAP and get back to it.

@ashokrayal
Copy link
Contributor

Hi @Manav-03 ,

Are you still working on it?

@Manav-03
Copy link

Hi @ashokrayal,

I've been facing a lot of issues with my system, I'll just un-assign myself.

@Manav-03 Manav-03 removed their assignment Sep 12, 2020
@ashokrayal
Copy link
Contributor

@Manav-03 it's ok, If you want to take more time. I just wanted to know if you are still working on it.

I will be happy be help you in your issues.

@ashokrayal
Copy link
Contributor

ashokrayal commented Sep 12, 2020

@Manav-03 it's ok, If you want to take more time. I just wanted to know if you are still working on it.

I will be happy be help you in your issues.

I also step up the project on my system recently.
I just created new environment and .env file.
I also commented requirements.txt file line 21-24 (docker related dependencies) and worked.

@Manav-03
Copy link

@ashokrayal I've tried all of that but the issue just seems to be something with my system and it's taking me a lot of time to figure it out. I think it's best if I try to figure that out instead of keeping this issue unavailable for people who could actually work on it. I'll take up another issue once I've sorted the issues with my system out :)

@vj-codes vj-codes added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Sep 12, 2020
@ashokrayal
Copy link
Contributor

Hi @vj-codes / @paritoshsinghrahar ,

I would like to work on this issue. I have no issues in progress. I already asked the same on 29th Aug.

Thanks

@vj-codes
Copy link
Member

Assigning you @ashokrayal
Happy coding!

@vj-codes vj-codes removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Sep 12, 2020
@ashokrayal
Copy link
Contributor

Assigning you @ashokrayal
Happy coding!

thanks @vj-codes.

@vj-codes vj-codes added Status: Available Issue was approved and available to claim or abandoned for over 3 days. and removed Open Source Hack labels Feb 18, 2021
@battuAshita
Copy link
Contributor

battuAshita commented May 3, 2021

Hi @vj-codes. Is this issue open? If it is, then I would like to work on this.

@vj-codes
Copy link
Member

vj-codes commented May 3, 2021

Assigning you @battuAshita
Happy coding!

@vj-codes vj-codes removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label May 3, 2021
@battuAshita
Copy link
Contributor

battuAshita commented May 5, 2021

Hi @vj-codes. While working on this issue, initially, the server was not able to connect to the database config through the .env file. So, I have added the line load_dotenv() to the config.py file and this worked for me. Should I commit this change also along with the other changes?

Also, is there a condition that each user can have more than one skill?

@epicadk
Copy link
Member

epicadk commented May 5, 2021

Hi @vj-codes. While working on this issue, initially, the server was not able to connect to the database config through the .env file. So, I have added the line load_dotenv() to the config.py file and this worked for me. Should I commit this change also along with the other changes?

No need

@epicadk
Copy link
Member

epicadk commented May 5, 2021

Also, is there a condition that each user can can more than one skill?

@isabelcosta thoughts please.

@battuAshita
Copy link
Contributor

Hi @vj-codes. I was running my test case but was unable to do it. I am getting the following error.
a
I am using postgres. How do I solve this issue? Please guide.

@vj-codes
Copy link
Member

vj-codes commented May 8, 2021

@battuAshita heyy are you using FLASK_ENVIRONMENT_CONFIG as local and you should not have the db variables in your .env file

@battuAshita
Copy link
Contributor

battuAshita commented May 9, 2021

@battuAshita heyy are you using FLASK_ENVIRONMENT_CONFIG as local and you should not have the db variables in your .env file

Yes, I am using it as local.
I should be using test while running the tests right?

@battuAshita
Copy link
Contributor

Hi @vj-codes. I was running my test case but was unable to do it. I am getting the following error.
a
I am using postgres. How do I solve this issue? Please guide.

This issue has been resolved. Thank you.

@battuAshita
Copy link
Contributor

I have raised a PR. Please review it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug.
Projects
None yet
7 participants