Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug : fix login signup and confirm tests to expect buttons disabled. #1098

Open
epicadk opened this issue Feb 24, 2021 · 0 comments · May be fixed by #1099
Open

Bug : fix login signup and confirm tests to expect buttons disabled. #1098

epicadk opened this issue Feb 24, 2021 · 0 comments · May be fixed by #1099
Assignees
@epicadk
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. Type: Testing UI Tests, Integration Tests, Travis CI, etc.
Milestone
1st MVP

Comments

@epicadk
Copy link
Member

epicadk commented Feb 24, 2021 •
edited
Loading

Describe the bug

Currenlty, The tests expect that the signup login and change password buttons are enabled even when some fields are empty. However as discussed in the mentorship session the buttons should be disabled when the user has not filled up all the required fields.
To Reproduce

  1. Run the existing ui tests.

Expected behavior

Tests should take into account this behavior.

Additional context

Self assigning as it should have been fixed in #1030 and has been discussed in the same pr. This was also discussed in the mentorship session.
@epicadk epicadk self-assigned this Feb 24, 2021
@epicadk epicadk added Type: Testing UI Tests, Integration Tests, Travis CI, etc. Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. labels Feb 24, 2021
@epicadk epicadk changed the title Bug : fix login and signup tests to expect buttons disabled. Bug : fix login signup and confirm tests to expect buttons disabled. Feb 24, 2021
epicadk added a commit to epicadk/mentorship-android that referenced this issue Feb 24, 2021
@epicadk
Fixed tests so that they expect button to the disabled anitab-org#1098
91a7607
@epicadk epicadk linked a pull request Feb 24, 2021 that will close this issue
Open
8 tasks
@devkapilbansal devkapilbansal added this to the 1st MVP milestone May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epicadk epicadk

Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. Type: Testing UI Tests, Integration Tests, Travis CI, etc.
Projects
None yet
Milestone
1st MVP
Development

Successfully merging a pull request may close this issue.

Fixed tests so that they expect button to the disabled #1098 epicadk/mentorship-android
2 participants
@devkapilbansal @epicadk