Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Credit Count Bug #1167

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Fixed Credit Count Bug #1167

merged 1 commit into from
Nov 24, 2024

Conversation

MICHAELMUNAVU83
Copy link
Collaborator

  • We had a bug where the credit points of a user and profile were not being shown correctly on the sidebar and the user profile page as such, we now calculate this value correctly.
Untitled.design.1.mp4

@MICHAELMUNAVU83 MICHAELMUNAVU83 marked this pull request as ready for review November 24, 2024 13:01
Copy link
Collaborator

@wintermeyer wintermeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the code but do wonder if we can increase the speed by using FastUser here or even create a new function just for this. AFAIK now we load not just the gorilla but the whole jungle too.

@briankariuki or @MICHAELMUNAVU83 Please have a look at this and improve in case it as bad as I think it is.

@wintermeyer wintermeyer merged commit b2e9ff8 into main Nov 24, 2024
1 check passed
@wintermeyer wintermeyer deleted the fix-credit-count-bug branch November 24, 2024 16:14
@MICHAELMUNAVU83
Copy link
Collaborator Author

Yeah , took some inspiration from some of @briankariuki code for fast user , a PR is coming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants