Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making the top_navigation_bar its own nested liveview #1129

Open
wintermeyer opened this issue Nov 6, 2024 · 1 comment
Open

making the top_navigation_bar its own nested liveview #1129

wintermeyer opened this issue Nov 6, 2024 · 1 comment
Assignees
Milestone

Comments

@wintermeyer
Copy link
Collaborator

Let’s do this:
Note that due to liveview's double remounting the queries fetching for random interests are executed twice. We can improve this by making the top_navigation_bar its own nested liveview, which would save the number of sql queries executed even on navigation to other routes.

@wintermeyer wintermeyer added this to the MVP milestone Nov 6, 2024
@briankariuki
Copy link
Collaborator

We may still have double remounting in the nested liveview (unless we use liveview's async_assigns), but since we can make it sticky, we'll save some sql queries on page navigations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants