Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO(mdc-migration) I need more than this #30455

Open
charlesritchea opened this issue Feb 6, 2025 · 0 comments
Open

TODO(mdc-migration) I need more than this #30455

charlesritchea opened this issue Feb 6, 2025 · 0 comments
Labels
docs This issue is related to documentation needs triage This issue needs to be triaged by the team

Comments

@charlesritchea
Copy link

charlesritchea commented Feb 6, 2025

Documentation Feedback

As you well know, it was all too easy to customize styles on Angular Material components prior to the MDC transition. Maybe it's just as easy now, but it's completely different. I understand why it's different, but since I'm just trying to upgrade a codebase that I didn't write. I have no idea how to do that or what any of these TODO comments mean.

   .my-user-edit-body {
    @extend .my-grid-cell-auto;
    @extend .my-grid;
    /* TODO(mdc-migration): The following rule targets internal classes of card that may no longer apply for the MDC version. */
    /* TODO(mdc-migration): The following rule targets internal classes of card that may no longer apply for the MDC version. */
    mat-card.my-user-edit-card {
      @extend .my-grid-cell-auto;
      @extend .my-grid;
      @extend .my-grid-center;
      /* TODO(mdc-migration): The following rule targets internal classes of card that may no longer apply for the MDC version. */
      mat-card-content.my-user-edit-card-content {
        @extend .my-grid;

        .my-user-information {
          @extend .my-grid-vertical;
          @extend .my-grid-cell-center;
          padding-left: 20px;

          .my-user-name {
            font-weight: bold;
          }
        }
      }
    }
  }
}

If you think that is clear then you have the curse of knowledge. That is incredibly obscure and I can't find any clear guide on what I'm supposed to do. The documentation essentially looks like the South Park Gnome Graph. Stack Overflow is full of people asking QUESTIONS about this, but no useful answers. I probably have over a thousand of these! Please offer some guidance here

Image

Affected documentation page

https://v15.material.angular.io/guide/mdc-migration#3-check-for-todos-left-by-the-migration-tool

@charlesritchea charlesritchea added docs This issue is related to documentation needs triage This issue needs to be triaged by the team labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This issue is related to documentation needs triage This issue needs to be triaged by the team
Projects
None yet
Development

No branches or pull requests

1 participant