fix(zone.js): do not silence uncaught promise rejections when the finally is called
#46462
Conversation
…nally` is called The native promise implementation logs unhandled promise rejections after `onFinally` has been called. We may rely on the `scheduledByFinally` argument, which is `false` by default, to avoid creating a breaking change; this will also allow us to reduce the number of changes. The `finally` function should not silence unhandled promise rejections, because they're not silenced in any implementation. If the `scheduleResolveOrReject` is called within the `finally` we won't clear unhandled rejections. We'll keep the same behaviour if the `scheduleResolveOrReject` is called within the `then`. PR Close angular#43206
|
@AndrewKushnir re-created as asked here: #45449 (comment). |
AndrewKushnir
added
target: minor
|
@arturovt thanks for re-creating the PR 👍 I will need to do some cleanup work in Google's codebase and let you know if I find any patterns that might need extra attention. Thank you. |
|
@arturovt unfortunately, this change caused a number of failures in Google's codebase. We'd need to discuss the next steps with the team, but the current state looks similar to #45447, see #45447 (comment). |
|
Closing since this breaks some tests internally, which would require some effort to investigate and land in g3. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
PR Type