"custom error Handler" invoked three times for each translate directive #1616

fmunafo · 2016-10-17T12:47:44Z

Why custom handler function is invoked three times using translateas attribute and six times using translateas element (three for the element and three for the attribute)?

(I've also noticed that with translate 2.10.0 it happens 4 and 8 times)

Thanks,
Filippo

<!doctype html>
<html ng-app="myApp">
  <head>
    <script src="https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.5.5/angular.js"></script>
    <script src="https://cdnjs.cloudflare.com/ajax/libs/angular-translate/2.12.1/angular-translate.js"></script>
  </head>
  <body>

    <div>
      <p translate="test_id_1"></p>
      <translate translate="test_id_2"></translate>
    </div>

    <script>
      var translations = {};

      var app = angular.module('myApp', ['pascalprecht.translate']);

      app.config(['$translateProvider', function ($translateProvider) {
        // add translation table
        $translateProvider
          .translations('en', translations)
          .useMissingTranslationHandler('myCustomHandlerFactory')
      }]);

      app.factory('myCustomHandlerFactory', function () {
        return function (translationID, uses) {
          if (translationID == "test_id_1") {
            console.log("handler per " + translationID);
            return 'NO VALUE FOR test_id_1';
          } else {
            console.log("handler per " + translationID);
            return 'NO VALUE FOR test_id_2';
          }
        };
      });  
    </script>
  </body>
</html>

The text was updated successfully, but these errors were encountered:

knalli · 2016-10-17T12:53:12Z

Hello,

as we had already mentioned in the issue's template, we need a working and as minimal as possible demo covering your specific use case or issue.

Follow these steps:

Please open this plnkr base.
Fork it (at the top left).
Ensure the version of AngularJS and angular-translate is correct.
Ensure all angular-translate plugins are available; reduce and remove anything you can.
Write a minimal as possible demo for your specific issue.
Save and freeze. Provide us the final link to your demo.

tspaeth · 2016-10-17T13:04:05Z

This looks already strange...

 <translate translate="test_id_2"></translate>

fmunafo · 2016-10-17T15:29:37Z

Here it's: https://plnkr.co/edit/FRgoJTVt8yrX8E25cvlU?p=preview

knalli · 2017-02-12T00:39:02Z

Translation will be tried for

observeElementTranslation(iAttr.translate);
updateTranslations(); (last one)
updateTranslations(); (in observe of translate)

fmunafo changed the title ~~"custom error Handler" invoked three or six times~~ "custom error Handler" invoked three times for each translate directive Oct 19, 2016

knalli added enhancement help wanted labels Feb 12, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

"custom error Handler" invoked three times for each translate directive #1616

"custom error Handler" invoked three times for each translate directive #1616

fmunafo commented Oct 17, 2016 •

edited

knalli commented Oct 17, 2016

tspaeth commented Oct 17, 2016

fmunafo commented Oct 17, 2016

knalli commented Feb 12, 2017

"custom error Handler" invoked three times for each translate directive #1616

"custom error Handler" invoked three times for each translate directive #1616

Comments

fmunafo commented Oct 17, 2016 • edited

knalli commented Oct 17, 2016

tspaeth commented Oct 17, 2016

fmunafo commented Oct 17, 2016

knalli commented Feb 12, 2017

fmunafo commented Oct 17, 2016 •

edited