Skip to content

[Bug]: Bottom bar visible on search screen #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks done
MaxMichel2 opened this issue Apr 2, 2025 · 2 comments
Open
3 tasks done

[Bug]: Bottom bar visible on search screen #1859

MaxMichel2 opened this issue Apr 2, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@MaxMichel2
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Is there a StackOverflow question about this issue?

  • I have searched StackOverflow

What happened?

When opening the app, if you click on the search button, the search screen opens with the keyboard by default.

If you close the keyboard, the bottom bar is still visible but has no tabs selected which seems to indicate that the bottom bar shouldn't be visible in the first place.

See the following screenshot:

Image

Relevant logcat output

Code of Conduct

  • I agree to follow this project's Code of Conduct
@MaxMichel2 MaxMichel2 added the bug Something isn't working label Apr 2, 2025
@rupenms
Copy link

rupenms commented Apr 3, 2025

Hi @MaxMichel2 I agree on search click, bottom menu icon is not highlighted. But if remove bottom bar altogether then user will have to first go back to the main screen by pressing the back button and then navigate to other screens. User will not be able to move to other tabs directly from search screen. Do you want this behavior ? Or else other option can be we can keep the bottom bar and highlight the tab option from which we moved to search screen. And when we click on the respective tabs it should move to that screen. If we click on the same tab which is highlighted when search screen is visible then it should go back/show that screen. Right now on clicking same screen tab on search screen it does not navigate to that screen.

@MaxMichel2
Copy link
Author

I don't know if there is a better solution out of those 2 🤔 For me it's a matter of preference. I can see the advantage of keeping the bottom bar and having the correct tab selected but the argument that the search screen is independent of all the tabs and thus has no business being visible is also valid.

YouTube is a good example of the first behaviour (keeping the bottom bar and current tab selected), it's visible when you open the notifications from the TopAppBar from any tab.

I think the active repo contributors will be more helpful in defining the expected behaviour here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants