Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing users to express disinterest in model.recommend #33

Open
andrewtavis opened this issue Apr 5, 2021 · 3 comments
Open

Allowing users to express disinterest in model.recommend #33

andrewtavis opened this issue Apr 5, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested

Comments

@andrewtavis
Copy link
Owner

This issue is for discussing and potentially implementing a way for users to express disinterest in a title when calling wikirec.model.recommend. The general idea now would be to allow users to pass a title with a negation indicator of some kind (ex "!title"), in which case the selections given the similarity matrix for the given item would be reversed.

It would be great to know if the above would be intuitive UI, and an implementation would be welcome!

@andrewtavis andrewtavis added enhancement New feature or request good first issue Good for newcomers question Further information is requested labels Apr 5, 2021
@andrewtavis andrewtavis added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Apr 7, 2021
@andrewtavis
Copy link
Owner Author

@victle, I figure we can discuss this in here :) v0.2.0 is out, btw! I'll do the example update tomorrow.

I'd like to go away from anything that's explicitly removing things with an arbitrary value - in reference to your idea of removing the top 10 recommendations for Twilight if someone negates it. Overall I think that the ratings are doing enough for this at the moment, and you've expressed interest in some other issues that I'd put higher on the priority list right now. Let's both think on this for the next few steps and come back to it, but I think that your idea of using negative values for disinterest is a good one that could be implemented simply :) Just so I understand it, that would be multiplying sim_matrix[i] by -1 before the arithmetic? Let me know if that's not what you meant by opposite vectors though 🙃

@victle
Copy link
Contributor

victle commented Apr 17, 2021

You're right, simply removing 10 recommendations does seem a bit archaic. I do agree that the ratings are doing decently well for expressing disinterest, so we can definitely put this on the backburner 😃 . And yep! I believe multiplying by -1 should be sufficient. My only concern is it might push the similarity matrix into a region we don't want.

@andrewtavis
Copy link
Owner Author

Let's keep the -1 implementation in mind then :) I think that it's intuitive enough that it wouldn't distract, and would allow people to further quickly find the opposite recommendations for things (could be really bad) 😄 What would your suggestion be for the UI on it? !title or ~title are the ones that jump out first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants