Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window resolution abnormal #159

Closed
syslot opened this issue Apr 9, 2024 · 12 comments
Closed

Window resolution abnormal #159

syslot opened this issue Apr 9, 2024 · 12 comments

Comments

@syslot
Copy link

syslot commented Apr 9, 2024

When I update the new version 1.0.13, the extension's window resuolution is abnormal.
Screenshot 2024-04-09 at 11 36 20

@andrewnguonly
Copy link
Owner

@syslot, thanks for reporting the issue! What browser and browser version are you using?

@syslot
Copy link
Author

syslot commented Apr 9, 2024

I tested this with two browser:

  1. Chrome with Version 122.0.6261.129 (Official Build) (x86_64)
  2. Arc Version 1.37.0 (48361) Chromium Engine Version 123.0.6312.106

@andrewnguonly
Copy link
Owner

I'm testing with Chrome version 123.0.6312.107 and I can't reproduce the issue. I'll test with Arc next. The screenshot looks like it's from Arc.

@syslot
Copy link
Author

syslot commented Apr 10, 2024

this pic is captured in chrome

@andrewnguonly
Copy link
Owner

Can you inspect popup window and check the width of the popup class? What does it show?

I can reproduce the issue if I remove the width attribute of the popup class.

.popup {
  /* width: 550px; */
  padding: 10px;
}

@syslot
Copy link
Author

syslot commented Apr 10, 2024

It doesn't match the situation you described. For the reason that I can't find the popup segment in style. Is it unexpected width of the container?

@andrewnguonly
Copy link
Owner

The expected width of the popup is 550px, as specified in Popup.css. If you don't see the popup class, then something is very wrong 😅

Can you try deleting the dist folder/files and rebuilding the entire app (i.e. npm run build)?

@syslot
Copy link
Author

syslot commented Apr 11, 2024

The expected width of the popup is 550px, as specified in Popup.css. If you don't see the popup class, then something is very wrong 😅

Can you try deleting the dist folder/files and rebuilding the entire app (i.e. npm run build)?

Thanks for your reply.
I've fellowed your advice , remove all project source code and re-clone it. After execute cmd : npm run build and load the dist fold, I found two errors in my extension page; here are :

image image

Is this the problem?

@andrewnguonly
Copy link
Owner

It's possible that there's a CSS class name collision with another extension. I'm going to update the class names to see if that helps.

@andrewnguonly
Copy link
Owner

@syslot, can you try version 1.0.14?

@andrewnguonly
Copy link
Owner

Hey @syslot, just checking in. Does version 1.0.14 resolve your issue?

@andrewnguonly
Copy link
Owner

Closing this issue for now. @syslot, if the issue is still present in the latest release, please re-open this issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants