Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle merge references correctly #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

otsenkun
Copy link

fixes #59

@otsenkun
Copy link
Author

Hi,

Thanks for the work you've done already :)
Let me know if I missed anything on this pull request

@otsenkun
Copy link
Author

Hi @andrewlock, I was wondering if you can take a look at this anytime soon :)

@andrewlock
Copy link
Owner

Hi @otsenkun, thanks for this, merge keys aren't something I've ever run into! Unfortunately, this will technically be a breaking change, so I think we may need to put the behaviour behind a feature flag.

Also, would it be possible to add some additional tests for basic Anchors and Aliases (without merge keys), just to confirm we haven't changed existing behaviour?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge references are not correctly handled
2 participants