Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using AddJsonStream #50

Open
wayne-o opened this issue Nov 13, 2019 · 1 comment
Open

Consider using AddJsonStream #50

wayne-o opened this issue Nov 13, 2019 · 1 comment
Assignees

Comments

@wayne-o
Copy link
Contributor

wayne-o commented Nov 13, 2019

It was added in netcore 3.0.0-preview6 and would mean we can delete some of the code I needed to copy over from the netcore source.

Would this be favorable? If so i can look to adding a PR

@andrewlock
Copy link
Owner

Interesting, on the one hand it does make sense, but given this code is supposed to support .NET Core 2.1 as well it's probably not going to be possible.

Plus the fact that VaultSharp uses Newtonsoft.Json under the hood, so you're always going to be pulling that in as a dependency anyway.

Feel free to give it more of a look if you like, but probably not worth the effort at this stage I suspect 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants