Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adzone should not force contrib.sites on project #39

Open
andrewebdev opened this issue Jul 16, 2014 · 1 comment
Open

Adzone should not force contrib.sites on project #39

andrewebdev opened this issue Jul 16, 2014 · 1 comment

Comments

@andrewebdev
Copy link
Owner

Having a adzone depend on sites is not really ideal. This situation comes up with projects that don't really require multi site support (which is probably most projects tbh). Authors may not even include the sites package at all, but will be forced to do so, just so that they can run this app.

I feel that if a client/dev wants site support, they should add this relation to the child models that inherits from Adbase.

@alexkahn
Copy link

I've located the dependencies in models.py and managers.py - wouldn't they just need to be deleted? Not sure how one would include sites support, possibly a setting? I am planning on integrating this application into one of my projects so I'd be happy to work the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants