Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small mistake in code #23

Open
saadtaame opened this issue Dec 7, 2015 · 2 comments
Open

Small mistake in code #23

saadtaame opened this issue Dec 7, 2015 · 2 comments

Comments

@saadtaame
Copy link

In the following piece of code I think you meant to write if(c >= 'A' && c <= 'F').

hexnumberc(int c)
{
    if(numberc(c))
        return 1;
    if(c >= 'a' && c <= 'f')
        return 1;
    if(c >= 'F' && c <= 'F')
        return 1;
    return 0;
}
@andrewchambers
Copy link
Owner

Good spotting, up until now I have been reviewing myself.

If you want credit you can make a pull request for this. No need to make a test case, I will add one.

@andrewchambers
Copy link
Owner

This is fixed, though I won't close until I add some more tests. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants