Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclosed sockets on exit #54

Closed
SamuelYvon opened this issue Sep 20, 2023 · 4 comments
Closed

Unclosed sockets on exit #54

SamuelYvon opened this issue Sep 20, 2023 · 4 comments

Comments

@SamuelYvon
Copy link
Contributor

This library has not been updated in a bit; I'm not sure I'll get an answer. In the threaded discovery service, a selector is opened and sockets are shoved in as needed. However, those sockets are never closed when stopping the service
@andreikop
Copy link
Owner

@SamuelYvon I don't support the library actively now, but do merge PRs

@SamuelYvon
Copy link
Contributor Author

I have a fork I can adapt for this which closes all the sockets. I'll contribute later if I have time

@SamuelYvon
Copy link
Contributor Author

@andreikop See #55

@andreikop
Copy link
Owner

Merged #55
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreikop @SamuelYvon