Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve mistake in README #629

Merged

Conversation

Rageking8
Copy link
Contributor

Casting from Derived to Base is an upcast and not a downcast.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (a8e7fba) to head (d2b43f7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #629   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files          21       21           
  Lines        6327     6327           
=======================================
  Hits         6170     6170           
  Misses        157      157           
Flag Coverage Δ
insights-macos 96.86% <ø> (ø)
insights-ubuntu-amd64-libcxx-No 97.95% <ø> (ø)
insights-ubuntu-amd64-libcxx-Yes 98.01% <ø> (ø)
insights-ubuntu-arm64-libcxx-No 97.89% <ø> (ø)
insights-ubuntu-arm64-libcxx-Yes ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreasfertig andreasfertig merged commit 6dfd5fd into andreasfertig:main Apr 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants