Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using new TZM geo/geo-types #32

Open
nyurik opened this issue Apr 7, 2022 · 0 comments
Open

Consider using new TZM geo/geo-types #32

nyurik opened this issue Apr 7, 2022 · 0 comments

Comments

@nyurik
Copy link

nyurik commented Apr 7, 2022

Would it make sense to migrate all internal postgis types to the proposed geo-types that support T, Z, and M generic types? Are there any changes that should be made to that proposal? How should SRID be added to it? One option might be to double the number of types - e.g. LineString, LineStringM, LineStringZ, LineStringZM, LineStringS, LineStringMS, LineStringZS, LineStringZMS, where all of them are aliases to pub struct LineStringTZM<T: CoordNum, Z: ZCoord, M: Measure, S: SRID>(...) -- where SRID could be defined as either i32 or NoValue.

If SRID is not accepted to geo/geo-types as an i32 (which seems to be a postgis convention only), one option would be to have some sort of a wrapper enum as described in georust/wkt#91 with an additional i32 srid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant