Skip to content
This repository has been archived by the owner on Jun 14, 2022. It is now read-only.

"Hidden" text should be shortened #880

Open
smurfix opened this issue Jul 30, 2021 · 6 comments · May be fixed by #935
Open

"Hidden" text should be shortened #880

smurfix opened this issue Jul 30, 2021 · 6 comments · May be fixed by #935
Assignees
@flocke
Labels
enhancement good first issue help wanted
Milestone
v0.9.1

Comments

@smurfix
Copy link

smurfix commented Jul 30, 2021 •
edited

General information

  • App version: 0.9
  • App source: Google Play
  • Android Version: 10
  • Custom ROM: no

Expected result

The "Hidden" text which replaces the token numbers is displayed as two lines if there's not enough room. This is annoying, for obvious reasons, more so if the phone happens to be horizontaly and vertically small. :-P

IMG_20210730_180546

Fix: simply replace that text with "••• •••". Or shrink the field until it fits in one line. Scrolling would work, too.

Steps to reproduce

  • install on small phone and set it to German. Alternately replace the "Hidden" text with something really long.
@flocke flocke added this to the v0.9.1 milestone Jul 30, 2021
@jsoberg
Copy link
Contributor

jsoberg commented Jul 31, 2021

I also notice from your screenshot that the Issuer/Label texts appear to be cutoff, so that might be something to look into as well.

@smurfix
Copy link
Author

smurfix commented Jul 31, 2021

No, the issuer+label texts are scrolling by just fine.

@Aryan20
Copy link

Aryan20 commented Aug 4, 2021

One way of solving it could be the removal of copy button, you can already assign the function to single tap or double tap.

@smurfix
Copy link
Author

smurfix commented Aug 4, 2021

@Aryan20 Might I suggest that it's somewhat easier, not to say more intuitive, to replace the "Hidden" text with six non-translated bullets?

@Aryan20
Copy link

Aryan20 commented Aug 4, 2021

I just suggested it because some TOTP can be 8 digits too, anyway it was just a suggestion :)

@o-alquimista o-alquimista linked a pull request Dec 31, 2021 that will close this issue
Open
@o-alquimista
Copy link

I made a PR that fixes this using six bullets, as suggested. The translatable "Hidden" label is kept as a description for accessibility purposes.

#935

Screenshot_1640974613

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@flocke flocke

Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
v0.9.1
Development

Successfully merging a pull request may close this issue.

Replace 'Hidden' with bullet placeholders o-alquimista/andOTP
5 participants
@flocke @smurfix @jsoberg @o-alquimista @Aryan20