-
Notifications
You must be signed in to change notification settings - Fork 357
Consider using an upstream icon package #370
Comments
I really like the idea of outsourcing the maintenance of the icons. And since SuperTinyIcons actually provides a lot of Android vector drawables it should be fairly straight forward to merge them. Maybe I could write a small script that takes care of that. |
I think the service-icons are pretty essential when using this AndOTP. I like the idea of getting new service icons into AndOTP fast. Maybe SuperTinyIcons can help. |
Is this being worked on ? I would like to take a look at this. |
@vangyyy Sorry it took me so long to respond. Just as @alexanderadam said, I would be happy if you could look into it. I don't have a lot of time currently. |
If there are any other icons you would like, please let us know in https://github.com/edent/SuperTinyIcons/issues |
@vangyyy Did you get anywhere with this? Might try and get this done today |
@RichyHBM I am working on it. Though it isn't as straight forward as importing the icons from SuperTinyIcons repository. Couple icons do not work under Android as they are in android-vector-drawable folder. I guess whoever converted them never tested them. I will probably submit some PRs to their repository to get it working as well as to improve coverage (a lot of current andOTP icons are simply not available). As far as implementation goes I was thinking of adding the repository as git submodule, which could be updated between releases. What do you think ? |
Yes, I started working on something for this this morning, I have added STI as a submodule and am adding the icons via a gradle task. I imagine most of the work for this will be done in gradle as to automate as much as possible |
@vangyyy I'm the maintainer of SuperTinyIcons. Pull requests very welcome. The android-vectors were automatically converted, not sure why they don't work - but guidance welcome! |
Hey @edent I opened an issue on SuperTinyIcons about the broken vector images, I also noticed a could of them may be the wrong size? Hopefuly that will be fixed with SuperTinyIcons#189 Anyway, I have got it all working with andOTP in an automated way, we would just need to decide wether to exclusively use STI or how we would do it @flocke. For now I have removed our versions that were also in STI |
I have submitted a PR in STI that fixes the issue and also adds existing icons that were missing in android-vector-drawable folder. As for the missing icons from andOTP, I would suggest leaving them for now, but maybe create an issue in STI where we could list them and work on them. |
Upstream PR that fixes android drawables was merged. All of them should work now. There is one problem though. STI doesn't require from contributors generating android drawables, they are optional. So in the future newly added icons may become broken or worse ... may not be generated at all. |
The problem with this is that it will become a burden for contributors and may result in less icons being made for STI. The conversion itself can not be easily automated with a script. I found a tool that produces correct image 99% of the time. It is payed though. It can only be used once (more if you open new incognito session every time ... cookies). Another solution is to convert them manually before release, but that defeats the whole point of using it in a first place. |
Why not? $ ./vd-tool -c -in svgs/ -out vectors/ So couldn't this step added to the travis configuration where the build seem to happen anyway? PS: I'm not an Android or Java developer so please excuse if I am missing fundamental things here. |
I don't really see an issue, if an icon is missing a drawable it can just be done as an issue/pr, same as if the icon didn't exist |
There is also the option of collaborating with https://github.com/2factorauth/twofactorauth for this. The project already maintains a list of icons specifically tailored to two-factor-authentication-providing services. Both projects are related and would do well to share resources. |
Are they also offering vector icons? So far I just found low resolution raster images (i.e. those) which obviously will look ugly on high resolution displays. |
As far as I can tell, no. That would be the downside of using those icons. |
Closing this issue as we have a PR and all further discussion should happen there: #398 |
Idea reposted from Telegram. Please feel free to edit this issue's title/description.
Preparing and optimising icons doesn't really have much to do with TOTP. If possible, it might be a good idea to investigate outsourcing the icon maintenance to a third party.
There are several interesting icon projects around, one nice example is SuperTinyIcons: https://github.com/edent/SuperTinyIcons
This solves two problems:
The text was updated successfully, but these errors were encountered: