Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime-host meta tag never tested #1193

Open
schlessera opened this issue Apr 7, 2021 · 0 comments
Open

Runtime-host meta tag never tested #1193

schlessera opened this issue Apr 7, 2021 · 0 comments

Comments

@schlessera
Copy link
Collaborator

The runtime-host meta tag does not seem to be tested at all, as all the tests use a relative ampUrlPrefix and thus throw an exception in the related code.

try {
const url = new URL(host);
this._addMeta(head, 'runtime-host', url.origin);
} catch (e) {
this.log.warn('ampUrlPrefix must be an absolute URL');

I assume this is either an oversight or a bug in the tests.

@schlessera schlessera changed the title Runtime host never tested Runtime-host meta tag never tested Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant