Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipc\connect is not part of the IpcHub interface #208

Open
danog opened this issue Dec 20, 2024 · 2 comments
Open

Ipc\connect is not part of the IpcHub interface #208

danog opened this issue Dec 20, 2024 · 2 comments

Comments

@danog
Copy link
Contributor

danog commented Dec 20, 2024

This essentially makes the entire IpcHub interface useless, as custom IPC implementations (i.e. IPC over FIFO, IPC over shared memory, et cetera) cannot override the logic of Ipc\connect() without also uselessly reimplementing the ProcessContextFactory and process-runner.php.

@danog
Copy link
Contributor Author

danog commented Dec 20, 2024

The socketConnector can of course help, but again, it is not used by the default runContext logic, requiring copying a large amount of logic

@trowski
Copy link
Member

trowski commented Dec 21, 2024

The connect function doesn't make sense as part of the IpcHub interface (well… maybe as a static method). Rather it sounds like what you're looking for is a way to override the connection logic in process-runner.php.

Potentially an IpcConnector interface with a global instance which could be overridden by a bootstrap file specified on the command line, similar to what we did for workers.

The bootstrap file would be the most versatile solution, allowing any setup to be done before attempting to connect to the parent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants