-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default behavior when input and output files are different bit depths seems unexpected #39
Comments
This issue may have been introduced when the 32 bps output file option was added. When specifying an integral input and output file type ctlrender will, by default, match the bit depth of the input file. That's not supposed to be the case for floating point file types. Prior to adding 32f exr files, specifying -format exr caused the files to scale and write as expected. Now it seems as if ctlrender is trying to match the bit depth of the 10-bit input file and write a 10-bit EXR, hence the error. 16-bit exr should be the default for the .exr extension and scaling should happen automatically regardless of the bit depth of the integral input file. Alex Alexander Forsythe - Imaging Engineering Manager - Science and Technology CouncilAcademy of Motion Picture Arts and Sciences - Tel 310-247-3000 x3310 On Feb 3, 2014, at 3:10 PM, Scott Dyer [email protected] wrote:
|
In lieu of a default of 16-bits and automatic scaling regardless of the bit depth of the input file, the error message “EXR files only support 16 or 32 bps at the moment.” could be changed to say (since the code throwing the error clearly has knowledge of the requested bit depth) |
This incorporates several clarifications to the usage and error messages that come with ctlrender. Provides a temporary fix for ampas#39 by clarifying the reason why an EXR, which only supports 16 and 32 bps, will not be written when the input format implicitly defines an output bit depth other than 16 or 32 (e.g. input file is 10-bit DPX). Closes ampas#38
This incorporates several clarifications to the usage and error messages that come with ctlrender. Provides a temporary fix for ampas#39 by clarifying the reason why an EXR, which only supports 16 and 32 bps, will not be written when the input format implicitly defines an output bit depth other than 16 or 32 (e.g. input file is 10-bit DPX). closes ampas#38
When input file is 10-bit, and output file is 16-bit OpenEXR, the following error is received:
"exception thrown (oops...): EXR files only support 16 or 32 bps at the moment."
This may actually be the intended behavior, but it seems like ctlrender should automatically scale correctly when the input format is an integral file and the output file is floating point. Adding an explicit -format exr16 works but the default behavior seems different than it was prior to CTL 1.5.
To reproduce, run the following line using the Sony F35 IDT available from aces-dev on the SonyF35.StillLife.dpx file available from the reference images 'camOrig' directory also available on aces-dev. For testing, I have used the 10-bit S-Log DPX file through the Sony F35 IDT.
This throws the exception:
This will work:
The text was updated successfully, but these errors were encountered: